Attempt to address #120, _CONDA_SET_PROJ_LIB unsetting

[hobu]

Checklist

• [x] Used a personal fork of the feedstock to propose changes
• [x] Bumped the build number (if the version is unchanged)
• [ ] Reset the build number to 0 (if the version changed)
• [x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
• [ ] Ensured the license file is being packaged.

This attempts to address #120, but I'm not sure about the other deactivation scripts, so I only addressed bash. Please update as needed.

closes #120

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[xylar]

This attempts to address https://github.com/conda-forge/proj.4-feedstock/issues/120, but I'm not sure about the other deactivation scripts, so I only addressed bash. Please update as needed.

No one has reported a similar problem as in https://github.com/conda-forge/proj.4-feedstock/pull/100 for the other activation/deactivation scripts. Maybe we assume they're fine unless someone can suggest the equivalent syntax for them?

[xylar]

@conda-forge-admin, please rerender

[github-actions[bot]]

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/proj.4-feedstock/actions/runs/1968106827.

[xylar]

The errors are unrelated to the changes here:

Reading file '$SRC_DIR/test/gie/nkg.gie'
     -----
     FAILURE in nkg.gie(211):
     expected: 3275753.9111 321110.8658 5445041.8822 2020.0
     got:      3275753.909377121367   321110.862629641255   5445041.881752743   2020.000000000
     deviation:  3.635866 mm,  expected:  0.100000 mm
     -----
     FAILURE in nkg.gie(215):
     expected: 2391774.5535 615614.9100 5860965.8138 2020.0
     got:      2391774.548114618286   615614.906333823106   5860965.818464150   2020.000000000
     deviation:  8.012333 mm,  expected:  0.100000 mm
     -----
     FAILURE in nkg.gie(219):
     expected: 2107889.5097 895603.2085 5933242.3152 2020.0
     got:      2107889.501365525648   895603.205471481429   5933242.320781169   2020.000000000
     deviation:  10.477825 mm,  expected:  0.100000 mm
-------------------------------------------------------------------------------
total: 28 tests succeeded,  0 tests skipped,  3 tests FAILED!
-------------------------------------------------------------------------------

I'm not sure how the cropped up between #119 and now or what to do about them (other than report them upstream).

[xylar]

Looks like we need a patch: https://github.com/OSGeo/PROJ/pull/3106

[xylar]

@hobu, apologies for pushing changes to your branch. I hope you don't mind.

[xylar]

@TormodLandet, do you want to have a look at this and make sure it fixes #120?

[TormodLandet]

Trying out the patched version:

set -euo pipefail  # enable shell strict mode
source deactivate.sh

results in

-bash: _CONDA_SET_PROJ_LIB: unbound variable

You need to change the if-statement to something like

if [ -n "${_CONDA_SET_PROJ_LIB:-}" ]; then
    export PROJ_LIB="${_CONDA_SET_PROJ_LIB}"
    unset _CONDA_SET_PROJ_LIB
fi

[xylar]

Great, thanks!

[github-actions[bot]]

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

• linter: passed
• azure: passed

Thus the PR was passing and merged! Have a great day!