Re-enable ppc64le - Githubissues

conda-forge / proj.4-feedstock

A conda-smithy repository for proj.4.

BSD 3-Clause "New" or "Revised" License

4 stars 26 forks source link

Re-enable ppc64le #150

Closed xylar closed 3 months ago

xylar commented 3 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

closes #148

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

xylar commented 3 months ago

@conda-forge-admin, please rerender

xylar commented 3 months ago

I was able to successfully test @mwtoews' approach in https://github.com/conda-forge/pyproj-feedstock/pull/152 with the test build from #149. Since we don't (at least so far) know of any problems with ppc64le "in the wild", I think it's time to re-enable it and see how it goes.

xylar commented 3 months ago

@snowman2, @mwtoews, @hobu, @ocefpaf, any objections with me proceeding with this? I'll do my best to re-enable ppc64le where it's been disabled because of proj.

hobu commented 3 months ago

any objections with me proceeding with this?

Fine with me. The entire episode made me wonder if architecture pins were such a thing? It would seem would should have been able to shut off ppc64le from just the PROJ recipe and the rest of the dependencies would have cascaded without modification when they were rerendered. Am I misunderstanding how things could/should/do work?

xylar commented 3 months ago

It would seem would should have been able to shut off ppc64le from just the PROJ recipe and the rest of the dependencies would have cascaded without modification when they were rerendered. Am I misunderstanding how things could/should/do work?

No, unfortunately, that isn't how it works. While enabling of advanced architectures only happens if the packages from upstream feedstocks are already available, the same is not true of disabling them. Instead, each feedstock has to notice that ppc64le is failing, find out why (no proj package in this case), find out if that's on purpose (yes in this case) and then disable ppc64le themselves. Likewise, reenabling ppc64le will be a (perhaps painful) manual process.

ocefpaf commented 3 months ago

We never had a case like this one before. While we could implement something in the bot I wonder how many other similar cases we will have to make it worth the effort.

xylar commented 3 months ago

I also think it's too specific to worry about having the bot handle such a case.

xylar commented 3 months ago

I'll proceed tomorrow morning (European time) if I haven't heard any objections.