conda-forge / prospector-feedstock

A conda-smithy repository for prospector.
BSD 3-Clause "New" or "Revised" License
0 stars 8 forks source link

Bump to version 1.9.0 #39

Closed valeriupredoi closed 1 year ago

valeriupredoi commented 1 year ago

Hello @conda-forge/prospector folks, we are big fans of prospector and have been using it for a while now; unfortunately the noarch one on conda-forge is rather old (1.7.7) and we'd like to move on to support Python=3.11, and use the latest prospector. So I am opening this see maybe I can help with the conda package for 1.9.0 - hope you don't mind me doing so 🍺

Closes #35 #36 #37 #38

Checklist

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

valeriupredoi commented 1 year ago

@conda-forge-admin, please rerender

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

valeriupredoi commented 1 year ago

OK folks, I have now included all the v1.9.0 up to date packages and their pins, but there is one roadblock: requirements-detector that is only at 0.7 on conda-forge; I have opened a PR to bump the version on their feedstock at https://github.com/conda-forge/requirements-detector-feedstock/pull/18 - but until that gets resolved, any way the >=1.0.3 pin you have can be relaxed? :beer:

valeriupredoi commented 1 year ago

OK folks, some progress update wrt requirements-detector - I have identified the pkg that blocks the update of that, and opened https://github.com/landscapeio/requirements-detector/pull/44 to retire it, also my colleague @zklaus is making requirements-detector noarch in https://github.com/conda-forge/requirements-detector-feedstock/pull/19

valeriupredoi commented 1 year ago

@zklaus @jakirkham - tests pass well now yay! Still a bit of cleanup to be done, will try do it later today from the airport, but we on a good path 😁

valeriupredoi commented 1 year ago

Ok folks, @zklaus @jakirkham @bouweandela I have now cleaned up the recipe (apologies for the clunky set of commits, doing this off my phone), I think we should be good to merge this. The reason why I tag Klaus and Bouwe is that it may be a good idea for all three of us to be repo maintainers here - since we use prospector actively, we could fix things here in good time, and get a bit of the burden off the other maintainers, but I'll leave that up to you @jakirkham - a next PR maybe to add us as maintainers. Cheers 🍺

valeriupredoi commented 1 year ago

friendly ping @conda-forge/prospector folks :beer:

jakirkham commented 1 year ago

Also do you want to add yourself as a maintainer here?

valeriupredoi commented 1 year ago

@jakirkham great to have your reply and review, mate, very many thanks! I have plugged in the suggested deps changes - good spotting and alignment with upstream! I have also added myself as repo maintainer/codeowner here; about sorting the deps - totally with you on that, but if they don't do it upstream, we should probably just wait on them to first do it there. Can suggest that via a PR sometime, my main priority is to first get this outta the way so we can finally Py311 it :grin:

valeriupredoi commented 1 year ago

@conda-forge-admin, please rerender

jakirkham commented 1 year ago

Thanks @valeriupredoi! 🙏

Yeah dependency ordering is not a blocker. Mostly noting since there are a lot of dependencies and it is a little hard atm to compare line-by-line atm with different ordering schemes. So it seems like something we would want to improve for maintainability reasons. Maybe we can track this in an issue

Thanks again for all your hard work here ❤️

valeriupredoi commented 1 year ago

@jakirkham you are a legend! Great many thanks! I shall open an issue and to upstream suggesting reordering their deps, maybe even a PR if I feel generous - will defo fix it here once they do that upstream. Cheers muchly for all the help here :beer: