search

conda-forge / psiturk-feedstock

A conda-smithy repository for psiturk.
BSD 3-Clause "New" or "Revised" License
0 stars 3 forks source link

readline for gnureadline, license info, tick build #6

Closed pmlandwehr closed 7 years ago

conda-forge-linter commented 8 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

deargle commented 8 years ago

@pmlandwehr what gives, why is it that psiturk can use gnureadline but you have to use readline in conda? Can you enlighten me?

And I just noticed that LICENSE was not found. I actually didn't include that file in the manifest for 2.1.6, I think... I'll go check.

EDIT: yeah it's not in 2.1.6. It's in master, though. So next tag will get it. Let me know if there's anything you need me to do sooner rather than later.

pmlandwehr commented 8 years ago

A bit of luck, really. Google show me this, which suggested the error could be caused by an older version of libreadline, and could be solved by including readline directly (or, alternately, by linking ncurses). conda-forge has feedstocks for both gnureadline and readline, but both are equally up-to-date. The latter feedstock, however, explicity links ncurses into the build while the former does not. (cc @jakirkham and @ocefpaf since the gnureadline feedstock might want a patch.)

jakirkham commented 8 years ago

cc @ocefpaf

jakirkham commented 8 years ago

IIRC gnureadline bundles its own copy of readline internally. I don't know how they build it, but would assume it is not linked to ncurses.

Sorry it's been awhile since I've touched gnureadline. I started building readline a long time back because it just avoided many problems and haven't looked back.

So does psiturk require gnureadline or is it an optional dependency? If the latter, maybe you could just drop it.

Are there any issues with ncurses or readline that I need to be aware of here?

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

pmlandwehr commented 7 years ago

Closing and re-forking since there are conflicts with travis.