conda-forge / psyplot-feedstock

A conda-smithy repository for psyplot.
BSD 3-Clause "New" or "Revised" License
0 stars 3 forks source link

psyplot v1.5.0 #26

Closed regro-cf-autotick-bot closed 4 months ago

regro-cf-autotick-bot commented 4 months ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: disabled to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8520373253, please use this URL for debugging.

conda-forge-webservices[bot] commented 4 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

github-actions[bot] commented 4 months ago

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

github-actions[bot] commented 4 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

Chilipp commented 4 months ago

hmm, not sure what is going wrong here. @valeriupredoi do you by chance have an idea? this package is now using versioneer for the version management, and in the pyproject.toml I add versioneer[toml] as build requirement (see https://github.com/psyplot/psyplot/blob/develop/pyproject.toml#L7). Therefore I added versioneer and tomli here as build requirement in meta.yaml, however it still complains, that it cannot find this library

Error log from Azure pipelines https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=908404&view=logs&jobId=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e&j=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e&t=6d4b912b-175d-51da-0fd9-4d30fe1eb4e7 ``` Processing $SRC_DIR Added file://$SRC_DIR to build tracker '/tmp/pip-build-tracker-diqs1fyc' Created temporary directory: /tmp/pip-modern-metadata-5xbiivmq Preparing metadata (pyproject.toml): started Running command Preparing metadata (pyproject.toml) Traceback (most recent call last): File "/home/conda/feedstock_root/build_artifacts/psyplot_1712149539581/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in main() File "/home/conda/feedstock_root/build_artifacts/psyplot_1712149539581/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main json_out['return_val'] = hook(**hook_input['kwargs']) File "/home/conda/feedstock_root/build_artifacts/psyplot_1712149539581/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 149, in prepare_metadata_for_build_wheel return hook(metadata_directory, config_settings) File "/home/conda/feedstock_root/build_artifacts/psyplot_1712149539581/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.10/site-packages/setuptools/build_meta.py", line 366, in prepare_metadata_for_build_wheel self.run_setup() File "/home/conda/feedstock_root/build_artifacts/psyplot_1712149539581/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.10/site-packages/setuptools/build_meta.py", line 311, in run_setup exec(code, locals()) File "", line 6, in ModuleNotFoundError: No module named 'versioneer' error: subprocess-exited-with-error × Preparing metadata (pyproject.toml) did not run successfully. │ exit code: 1 ╰─> See above for output. ```
valeriupredoi commented 4 months ago

hi @Chilipp - great to see you updated the pkgs, good one :beer: Apols, I was on holidays yesterday, let me have a looksee here :+1:

Chilipp commented 4 months ago

let me have a looksee here 👍

thanks a lot!

valeriupredoi commented 4 months ago

I think you'd need to add versioneer as a package dependency in your upstream pyproject.toml https://github.com/psyplot/psyplot/blob/develop/pyproject.toml as well, in dependencies or optional-dependencies - it fails at building the Python package that uses pyproject.toml - either that, or - even better - I'd get rid of --ignore-installed in your pip call - I think it's best to get the packages from conda forge and keep them, not overinstalling them from PyPI

Chilipp commented 4 months ago

alright!

I'd get rid of --ignore-installed in your pip call - I think it's best to get the packages from conda forge and keep them, not overinstalling them from PyPI

let's try that. thanks for the advice @valeriupredoi

valeriupredoi commented 4 months ago

fingers crossed :crossed_fingers:

github-actions[bot] commented 4 months ago

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

Chilipp commented 4 months ago

hmm, still the same @valeriupredoi

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=908445&view=logs&jobId=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e&j=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e&t=6d4b912b-175d-51da-0fd9-4d30fe1eb4e7

Chilipp commented 4 months ago

I just checked, and the versioneer-feedstock puts tomli into the host section for the requirements, and includes setuptools. so let me try that

https://github.com/conda-forge/versioneer-feedstock/blob/main/recipe/meta.yaml

github-actions[bot] commented 4 months ago

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

Chilipp commented 4 months ago

ok. this seems to have worked. now I just have to remove python 3.8 here

valeriupredoi commented 4 months ago

hmm that could be - but I also noticed that you require versioneer with PEP440 in your pyproject.toml (sorry, I missed that it was already required there), but pip builds with PEP517 - let's see the tests, seems they are going along with your last change :crossed_fingers:

Chilipp commented 4 months ago

@conda-forge-admin please rerender

github-actions[bot] commented 4 months ago

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

valeriupredoi commented 4 months ago

ah your fix worked, and no PEP conflicts either! I'd just drop support for Python 3.8 - you have it dropped in upstream anyway: ERROR: Package 'psyplot' requires a different Python: 3.8.19 not in '>=3.9' :grin: