Closed regro-cf-autotick-bot closed 4 months ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Hi! This is the friendly conda-forge automerge bot!
Commits were made to this PR after the automerge
label was added. For security reasons, I have disabled automerge by removing the automerge
label. Please add the automerge
label again (or ask a maintainer to do so) if you'd like to enable automerge again!
Hi! This is the friendly conda-forge automerge bot!
I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day!
hmm, not sure what is going wrong here. @valeriupredoi do you by chance have an idea? this package is now using versioneer
for the version management, and in the pyproject.toml
I add versioneer[toml]
as build requirement (see https://github.com/psyplot/psyplot/blob/develop/pyproject.toml#L7). Therefore I added versioneer
and tomli
here as build requirement in meta.yaml
, however it still complains, that it cannot find this library
hi @Chilipp - great to see you updated the pkgs, good one :beer: Apols, I was on holidays yesterday, let me have a looksee here :+1:
let me have a looksee here 👍
thanks a lot!
I think you'd need to add versioneer
as a package dependency in your upstream pyproject.toml
https://github.com/psyplot/psyplot/blob/develop/pyproject.toml as well, in dependencies or optional-dependencies - it fails at building the Python package that uses pyproject.toml
- either that, or - even better - I'd get rid of --ignore-installed
in your pip call - I think it's best to get the packages from conda forge and keep them, not overinstalling them from PyPI
alright!
I'd get rid of
--ignore-installed
in your pip call - I think it's best to get the packages from conda forge and keep them, not overinstalling them from PyPI
let's try that. thanks for the advice @valeriupredoi
fingers crossed :crossed_fingers:
Hi! This is the friendly conda-forge automerge bot!
Commits were made to this PR after the automerge
label was added. For security reasons, I have disabled automerge by removing the automerge
label. Please add the automerge
label again (or ask a maintainer to do so) if you'd like to enable automerge again!
I just checked, and the versioneer-feedstock
puts tomli
into the host
section for the requirements, and includes setuptools. so let me try that
https://github.com/conda-forge/versioneer-feedstock/blob/main/recipe/meta.yaml
Hi! This is the friendly conda-forge automerge bot!
Commits were made to this PR after the automerge
label was added. For security reasons, I have disabled automerge by removing the automerge
label. Please add the automerge
label again (or ask a maintainer to do so) if you'd like to enable automerge again!
ok. this seems to have worked. now I just have to remove python 3.8 here
hmm that could be - but I also noticed that you require versioneer with PEP440 in your pyproject.toml (sorry, I missed that it was already required there), but pip builds with PEP517 - let's see the tests, seems they are going along with your last change :crossed_fingers:
@conda-forge-admin please rerender
Hi! This is the friendly conda-forge automerge bot!
Commits were made to this PR after the automerge
label was added. For security reasons, I have disabled automerge by removing the automerge
label. Please add the automerge
label again (or ask a maintainer to do so) if you'd like to enable automerge again!
ah your fix worked, and no PEP conflicts either! I'd just drop support for Python 3.8 - you have it dropped in upstream anyway: ERROR: Package 'psyplot' requires a different Python: 3.8.19 not in '>=3.9'
:grin:
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have theconda-forge-admin
add it for you.Dependency Analysis
Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add
bot: inspection: disabled
to yourconda-forge.yml
. If you encounter issues with this feature please ping the bot teamconda-forge/bot
.Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.
Packages found by source code inspection but not in the meta.yaml:
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8520373253, please use this URL for debugging.