conda-forge / pulp-feedstock

A conda-smithy repository for pulp.
BSD 3-Clause "New" or "Revised" License
2 stars 9 forks source link

Use cbc from coin-or-cbc rather than binaries in pulp tar-ball #41

Open peterjc opened 2 months ago

peterjc commented 2 months ago

Checklist

If this works, it would close #27 and #40 by using the external dependency for the cbc binaries, rather than the limited set of pre-compiled cbc binaries bundled with the pulp tar-ball.

peterjc commented 2 months ago

@conda-forge-admin, please rerender

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

peterjc commented 2 months ago

@conda-forge-admin, please rerender

peterjc commented 2 months ago

Hmm. This looks like a common clue (even on the Mac builds):

Processing $SRC_DIR
  Added file://$SRC_DIR to build tracker '/tmp/pip-build-tracker-pbfcgnix'
  Running setup.py (path:$SRC_DIR/setup.py) egg_info for package from file://$SRC_DIR
  Created temporary directory: /tmp/pip-pip-egg-info-s0h25hal
  Preparing metadata (setup.py): started
  Running command python setup.py egg_info
  /home/conda/feedstock_root/build_artifacts/pulp_1723724843211/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.9/site-packages/setuptools/_distutils/dist.py:268: UserWarning: Unknown distribution option: 'test_suite'
    warnings.warn(msg)
  running egg_info
  creating /tmp/pip-pip-egg-info-s0h25hal/PuLP.egg-info
  writing /tmp/pip-pip-egg-info-s0h25hal/PuLP.egg-info/PKG-INFO
  writing dependency_links to /tmp/pip-pip-egg-info-s0h25hal/PuLP.egg-info/dependency_links.txt
  writing entry points to /tmp/pip-pip-egg-info-s0h25hal/PuLP.egg-info/entry_points.txt
  writing top-level names to /tmp/pip-pip-egg-info-s0h25hal/PuLP.egg-info/top_level.txt
  writing manifest file '/tmp/pip-pip-egg-info-s0h25hal/PuLP.egg-info/SOURCES.txt'
  error: package directory 'pulp/solverdir/cbc/linux/32' does not exist
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> See above for output.

Update: I'd left a delete command in before running pip install. Doh.

peterjc commented 2 months ago

Progress, my mistake again:

rm: cannot remove ‘/home/conda/feedstock_root/build_artifacts/pulp_1723725844498/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.8/site-packages/pulp/solverdir/cbc’: Is a directory

peterjc commented 2 months ago

Just a HTTP 502 BAD GATEWAY for the linux_aarch64_python3.9.____cpython run.

And an easy fix for the Windows failure:

'rm' is not recognized as an internal or external command,
operable program or batch file.
peterjc commented 2 months ago

Is there a way to download the packages built on this PR for local testing? (BioConda has a bot to help do that - I can't see any artifact links on Azure here)

tkralphs commented 2 months ago

You have to set up the workflow to archive artifacts using something like actions/upload-artifact, it's not automatic.