search

conda-forge / pyarrow-feedstock

A conda-smithy repository for pyarrow.
BSD 3-Clause "New" or "Revised" License
6 stars 26 forks source link

Update to 0.4.0 release, enable Parquet on Windows #30

Closed jreback closed 7 years ago

jreback commented 7 years ago

cc @wesm

the package looks good, just recipe needs updating.

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

wesm commented 7 years ago

You need to add --with-parquet to the bld.bat. That will fail until parquet-cpp-feedstock is updated to pick up PARQUET-992 https://github.com/apache/parquet-cpp/commit/6787492eccef3ba6ff891a6dad4f32ba09d268e7

wesm commented 7 years ago

This also needs https://github.com/apache/arrow/commit/fee44751048847ce1e08039ab72c09918b11b31b merged earlier today

wesm commented 7 years ago

I'm going to push a parquet-cpp update with the RC0 tag

jreback commented 7 years ago

done

wesm commented 7 years ago

Like I said, the build is going to fail until the parquet-cpp packages are updated.

wesm commented 7 years ago

As a conda-forge best practice, if you don't think a commit is going to make the build pass, it's better to not push it. The queue can sometimes be hours long (earlier this year we were sometimes waiting 12 or more hours for builds), so if you push known-bad-builds into the queue, it's just making other people's builds take longer.

wesm commented 7 years ago

The parquet-cpp packages are up to date now in anaconda.org. Can you bump the build hash here to the rc0 tag https://github.com/apache/arrow/tree/fea6b71468618d22ece16250ff75f23ba2f18914? Keep the version number as 0.3.0.post; we can do a 0.4.0 release after the vote passes

wesm commented 7 years ago

Just updated the commit hash to HEAD, hopefully this build will pass :)

wesm commented 7 years ago

Ah this needs latest arrow-cpp, working on that now

wesm commented 7 years ago

See https://github.com/conda-forge/arrow-cpp-feedstock/pull/22. I'm also going to update parquet-cpp to include PARQUET-995

wesm commented 7 years ago

See also https://github.com/conda-forge/parquet-cpp-feedstock/pull/22

wesm commented 7 years ago

I'm in the process of updating arrow-cpp, parquet-cpp is building. I'll update this for Arrow 0.4.0 final; hopefully we'll get a passing build on Windows, then

wesm commented 7 years ago

I think this failed because parquet-cpp was built against an incompatible older commit of arrow-cpp, fixing that first, then will rebuild this

wesm commented 7 years ago

Updated the parquet-cpp build, triggered a new build here

wesm commented 7 years ago

Looks like maybe the parquet-cpp build was a red herring; adding snappy/brotli/thrift-cpp to run: Windows to see if that fixes things

wesm commented 7 years ago

Phew it worked. So we have some static linking problem in parquet-cpp on Windows; I will figure out what it is later and open a JIRA