conda-forge / pybamm-feedstock

A conda-smithy repository for pybamm.
BSD 3-Clause "New" or "Revised" License
2 stars 8 forks source link

Package the IDAKLU solver in the recipe #65

Open agriyakhetarpal opened 3 hours ago

agriyakhetarpal commented 3 hours ago

This is a medium-term issue that we should start considering to do since PyBaMM will migrate to using the IDAKLU solver as the default instead of the CasadiSolver.

This requires fixing the sdist, compiling SuiteSparse, and compiling SUNDIALS with KLU linked from SuiteSparse. We might need to patch PyBaMM to not use the CasADi Python package and compile the C interface ourselves (with minimal interfaces), and later turn binary relocation on for the feedstock. We could also introduce additional extension modules for this task.

We can then remove it and package pybammsolvers as a separate conda-forge feedstock to use here as a dependency once i. https://github.com/pybamm-team/PyBaMM/pull/4487 is done and ii. things are stable enough for at least one release after the transition

agriyakhetarpal commented 3 hours ago

This is where I begin to feel that migrating to Meson instead of scikit-build-core might have been better – no one wants to deal with CMake 😃