conda-forge / pycapnp-feedstock

A conda-smithy repository for pycapnp.
BSD 3-Clause "New" or "Revised" License
1 stars 7 forks source link

bump build number #32

Closed garymm closed 9 months ago

garymm commented 9 months ago

I'm hoping this will produce a package compatible with capnproto 1.0

Checklist

conda-forge-webservices[bot] commented 9 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

garymm commented 9 months ago

@conda-forge-admin, please rerender

garymm commented 9 months ago

Hmm I guess something about the Cython compiler changed? Not even sure what is responsible for compiling Cython. Here's the error:

[1/1] Cythonizing capnp/lib/capnp.pyx
warning: capnp/includes/capnp_cpp.pxd:364:17: Rvalue-reference as function argument not supported
performance hint: capnp/lib/capnp.pyx:297:5: Exception check on 'make_reader_opts' will always require the GIL to be acquired. Declare 'make_reader_opts' as 'noexcept' if you control the definition and you're sure you don't want the function to raise exceptions.

Error compiling Cython file:
------------------------------------------------------------
...
    cdef _init(self, capnp.DynamicEnum other, object parent):
        self.thisptr = other
        self._parent = parent
        return self

    cpdef _as_str(self) except +reraise_kj_exception:
          ^
------------------------------------------------------------

capnp/lib/capnp.pyx:1011:10: Only extern functions can throw C++ exceptions.
garymm commented 9 months ago

@conda-forge-admin, please rerender

github-actions[bot] commented 9 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pycapnp-feedstock/actions/runs/7923558370.

conda-forge-webservices[bot] commented 9 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-webservices[bot] commented 9 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

garymm commented 9 months ago

@conda-forge-admin, please rerender

garymm commented 9 months ago

@LehMaxence looks like this is good to go. Adds python 3.11 and capnproto 1.x support.

LehMaxence commented 9 months ago

@LehMaxence looks like this is good to go. Adds python 3.11 and capnproto 1.x support.

Just curious why do you say it adds capnproto 1.x support?

Right now all the CI jobs use 0.10.2 because that's what is pinned so I'm not sure it actually works with v1. There's a PR open to pin v1.

garymm commented 9 months ago

Just curious why do you say it adds capnproto 1.x support?

Because I'm a noob and I was wrong. I thought any version not specified in meta.yaml would use the latest version. Anyways I'd like both py 3.11 and capnproto 1.x support, so I guess this PR gets us halfway there. Any idea how to move that other PR forward?

LehMaxence commented 9 months ago

No worries, I was just wondering if you tried it out some other way.

You can probably ping conda-forge/core in the pinning PR to see if someone can look at it.

LehMaxence commented 9 months ago

Anyway I can merge this PR, and when the pinning is updated, the bot will open a new one here to update the package.