Closed kenibrewer closed 7 months ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
ModuleNotFoundError: No module named 'cytominer_database'
one step closer!
@conda-forge-admin please rerender
Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/pycytominer-feedstock/actions/runs/6750680064.
@conda-forge-admin please rerender
Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.
This message was generated by GitHub actions workflow run https://github.com/conda-forge/pycytominer-feedstock/actions/runs/6750696507.
FYI, there's an issue with how we do the imports in pycytominer we are working on fixing that is probably required for this to build correctly. https://github.com/cytomining/pycytominer/issues/350
yes. I've been following the cross referenced issues. just wanted to help get one step closer while you work on the upstream issyes
@gwaybio @hmaarrfk This is ready for review.
I would add tests for each of your subpackages. do they have a unique thing you can import?
@conda-forge-admin please rerender
Picking up this issue again.
I would add tests for each of your subpackages. do they have a unique thing you can import?
Yes the cytominer_database
and boto3
are unique imports for the collate
and cell_locations
subpackages respectively. I went through the documentation on conda recipes, and couldn't figure out how to add tests specific to a subpackage. Is there an example you could direct me to?
I often use opencv as an example: https://github.com/conda-forge/opencv-feedstock/blob/main/recipe/meta.yaml#L241
@hmaarrfk @gwaybio This is ready for review.
do you mind adding yourself as a maintainer in this PR? I'm not sure we have established that @gwaybio is inactive, but I'll take his silence on this feedstock in recent months them being OK with your help.
👍 for adding @kenibrewer as maintainer - he is currently a maintainer for the main package. Thanks!
Hi! This is the friendly conda-forge automerge bot!
I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day!
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)This fixes missing poetry dependency from build process.