257 2 - Githubissues

conda-forge / pyemma-feedstock

A conda-smithy repository for pyemma.

BSD 3-Clause "New" or "Revised" License

2 stars 7 forks source link

257 2 #30

Closed marscher closed 4 years ago

marscher commented 4 years ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

marscher commented 4 years ago

@conda-forge-admin please rerender

marscher commented 4 years ago

@clonker for python-3.8 I guess we need to rebuild thermotools, msmtools and bhmm as well (prior this PR gets mergeable). Or would you prefer to skip the build for this Python version and stick more to scikit-time?

clonker commented 4 years ago

No you are right. It should be a matter of increasing the build number and rerendering right? If so I am going to prepare pull requests.

clonker commented 4 years ago

Actually I think for bhmm it would make sense to have a patch release even to include the RNG reseeding fix.

marscher commented 4 years ago

@conda-forge-admin please rerender

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

marscher commented 4 years ago

thanks @clonker for fixing all the perquisites