MNT: Add noarch: python

conda-forge / pygmt-feedstock

A conda-smithy repository for pygmt.

BSD 3-Clause "New" or "Revised" License

5 stars 3 forks source link

MNT: Add noarch: python #13

Closed conda-forge-linter closed 3 years ago

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice.

I've made the recipe noarch: python as instructed in #12.

Here's a checklist to do before merging.

[ ] Bump the build number if needed.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

noarch: python recipes are recommended to have a lower bound on the python version. This recommendation will become a requirement in the future.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

requirements: run: python >= 3.6 should not contain a space between relational operator and the version, i.e. python >=3.6

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

moorepants commented 3 years ago

Ping @moorepants (since you have more conda-forge experience), do you see an issue with moving to noarch Python builds here?

As long as pygmt is a pure Python package and there are no differences in the installation for different OSes it is fine.

moorepants commented 3 years ago

How does pygmt interact with gmt? You aren't compiling a Python C extension or anything?

weiji14 commented 3 years ago

How does pygmt interact with gmt? You aren't compiling a Python C extension or anything?

That's a good question. I don't think we compile any C extensions, @seisman do you know anything about this?

seisman commented 3 years ago

How does pygmt interact with gmt? You aren't compiling a Python C extension or anything?

That's a good question. I don't think we compile any C extensions, @seisman do you know anything about this?

No C codes in the pygmt project. PyGMT calls GMT's shared library via ctypes.

moorepants commented 3 years ago

PyGMT calls GMT's shared library via ctypes.

As long as that works universally on the 3 OSes, then you should be able to do to noarch: python.

weiji14 commented 3 years ago

Ok, noarch packages are up! I've installed it on Windows using conda install https://anaconda.org/conda-forge/pygmt/0.2.1/download/noarch/pygmt-0.2.1-pyhd8ed1ab_1.tar.bz2 and it seems to work-ish (though I'm getting an error, possibly due to https://github.com/GenericMappingTools/gmt/pull/4441).

E           pygmt.exceptions.GMTCLibError: Module 'psconvert' failed with status code 78:
E           psconvert [ERROR]: System call [@gswin64c -q -dNOSAFER -dNOPAUSE -dBATCH -sDEVICE=bbox -DPSL_no_pagefill -dMaxBitmap=2147483647 -dUseFastColor=true "C:/Users/username/.gmt/sessions/gmt_session.3708/gmt_30.ps-" 2> "C:/Users/username/.gmt/sessions/gmt_session.3708/psconvert_1804c.bb"] returned error 1.

.conda\envs\pygmt\lib\site-packages\pygmt\clib\session.py:506: GMTCLibError

But that's a separate issue I noticed before, and we'll sort that out upstream on GMT later.

Anyways, thanks @moorepants for the review!