Fix the wrong v0.0.0 version number

conda-forge / pygmt-feedstock

A conda-smithy repository for pygmt.

BSD 3-Clause "New" or "Revised" License

5 stars 3 forks source link

Fix the wrong v0.0.0 version number #15

Closed seisman closed 3 years ago

seisman commented 3 years ago

Problem with setuptools_scm not getting correct version. PR is based on https://github.com/conda-forge/pint-feedstock/pull/34.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

weiji14 commented 3 years ago

Cool. Could you add @willschlitzer to recipe/meta.yaml too as mentioned in https://github.com/conda-forge/pygmt-feedstock/pull/14#issuecomment-779398308?

seisman commented 3 years ago

Cool. Could you add @willschlitzer to recipe/meta.yaml too as mentioned in #14 (comment)?

Will do it later.

The changes above still don't work. I'm wondering do we also need to add these dependencies (https://github.com/conda-forge/pint-feedstock/pull/34/files)

    - setuptools >=45
    - setuptools_scm >=3.4
    - toml

weiji14 commented 3 years ago

Those appear to be host (i.e. build) dependencies, should be ok to add them.

seisman commented 3 years ago

Output from the CI job:

python -c 'import pygmt; pygmt.show_versions()'
PyGMT information:
  version: v0.3.0
System information:
  python: 3.9.1 | packaged by conda-forge | (default, Jan 26 2021, 01:34:10)  [GCC 9.3.0]
  executable: $PREFIX/bin/python
  machine: Linux-4.15.0-1106-azure-x86_64-with-glibc2.12
Dependency information:
  numpy: 1.20.1
  pandas: 1.2.2
  xarray: 0.16.2
  netCDF4: 1.5.6
  packaging: 20.9
  ghostscript: 9.53.3
  gmt: 6.1.1
GMT library information:
  binary dir: $PREFIX/bin
  cores: 2
  grid layout: rows
  library path: $PREFIX/lib/libgmt.so
  padding: 2
  plugin dir: $PREFIX/lib/gmt/plugins
  share dir: $PREFIX/share/gmt
  version: 6.1.1