Update windows - Githubissues

conda-forge / pygrib-feedstock

A conda-smithy repository for pygrib.

BSD 3-Clause "New" or "Revised" License

2 stars 8 forks source link

Open dopplershift opened 4 years ago

dopplershift commented 4 years ago

Compile against openjpeg for JPEG2k support and enable building against libpng.

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

dopplershift commented 4 years ago

I expect this to fail initially, but I want to patch setup.py as little as possible, so I'm waiting to see what fails here first.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

dopplershift commented 4 years ago

I'm wondering if there's actually an option to use openjpeg here. See jswhit/pygrib#123.

conda-forge-webservices[bot] commented 3 weeks ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

akrherz commented 3 weeks ago

5 years later... why not try a rebase, hehe

@conda-forge-admin please rerender

akrherz commented 3 weeks ago

@dopplershift I guess I am unsure about this PR now :)

dopplershift commented 3 weeks ago

I was never clear whether openjpeg was actually an option, so unsure if this accomplishes anything.