search

conda-forge / pymc3-feedstock

A conda-smithy repository for pymc3.
BSD 3-Clause "New" or "Revised" License
5 stars 17 forks source link

pymc3 v3.7 #38

Closed regro-cf-autotick-bot closed 5 years ago

regro-cf-autotick-bot commented 5 years ago

It is very likely that the current package version for this feedstock is out of date. Notes and instructions for merging this PR:

  1. Please check that the dependencies have not changed.
  2. Please merge the PR only after the tests have passed.
  3. Feel free to push to the bot's branch to update this PR if needed.
  4. The bot will almost always only open one PR per version.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one.

This PR was created by the cf-regro-autotick-bot. The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues!

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ericmjl commented 5 years ago

@conda-forge/help-python-c it looks like this is failing only on Python 2.7. Is this something we need to change here?

ocefpaf commented 5 years ago

@conda-forge/help-python-c it looks like this is failing only on Python 2.7. Is this something we need to change here?

Based on the error message skip Python 2.7 :smile: 

pymc3 requires Python '>=3.5.4' but the running Python is 2.7.15
ocefpaf commented 5 years ago

@conda-forge-admin, please rerender

ocefpaf commented 5 years ago

Windows and Python 3.6 is failing with:

    (status, compile_stderr.replace('\n', '. ')))
Exception: Compilation failed (return status=1): In file included from C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/lib/gcc/x86_64-w64-mingw32/8.1.0/include/c++/math.h:36,.                  from D:\bld\pymc3_1559152707984\_test_env\include/pyport.h:194,.                  from D:\bld\pymc3_1559152707984\_test_env\include/Python.h:53,.                  from C:\Users\VssAdministrator\AppData\Local\Theano\compiledir_Windows-10-10.0.14393-SP0-Intel64_Family_6_Model_63_Stepping_2_GenuineIntel-3.6.7-64\lazylinker_ext\mod.cpp:1:. C:/ProgramData/Chocolatey/lib/mingw/tools/install/mingw64/lib/gcc/x86_64-w64-mingw32/8.1.0/include/c++/cmath:1121:11: error: '::hypot' has not been declared.    using ::hypot;.            ^~~~~. 
Tests failed for pymc3-3.7-py36_0.tar.bz2 - moving package to D:\bld\broken

That is odd :-/

@conda-forge/pymc3 team does pymc3 have compiled parts? Can we make this noarch?

ocefpaf commented 5 years ago

@conda-forge/pymc3 team does pymc3 have compiled parts? Can we make this noarch?

I could not find any complied parts, looks like a pure Python and good candidate for noarch. Please revert the last commits if that is not true.

ericmjl commented 5 years ago

cc: @twiecki, @fonnesbeck, @ColCarroll, can you confirm that noarch is correct? I think it's correct, but the theano dependency makes me a bit nervous. (maybe my mental model is incorrect here)

ericmjl commented 5 years ago

Verbal confirmation from @twiekci. I am going to merge.