Rebuild 3.8 to fix missing geweke import

conda-forge / pymc3-feedstock

A conda-smithy repository for pymc3.

BSD 3-Clause "New" or "Revised" License

5 stars 17 forks source link

Rebuild 3.8 to fix missing geweke import #55

Closed maresb closed 3 years ago

maresb commented 3 years ago

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[X] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

Fixes https://discourse.pymc.io/t/6818

I'd like to rebuild the following versions in order to add arviz<0.11.2 in order to resolve the geweke module problem.

[X] v3.8
[ ] v3.9.1
[ ] v3.9.2
[ ] v3.9.3
[ ] v3.10.0

We may want to do this in a separate branch in order to keep master clean. I can't create a new branch myself since I'm not a maintainer on this feedstock.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

maresb commented 3 years ago

@conda-forge-admin, please rerender

maresb commented 3 years ago

I think I probably didn't explain so precisely what my intentions are...

There is a problem with the feedstocks from v3.8 to v3.10.0 inclusive, relating to how pymc3 depends on arviz. The problem is that v0.11.2 of arviz removed arviz.geweke. Unfortunately, the aforementioned pymc3 versions import this module on initialization. This means that pymc3 will be completely broken. The command import pymc3 will fail.

Now let's say I run mamba install -c conda-forge pymc3==3.10.10. Then mamba will install that version of pymc3, plus the latest "compatible" versions of its dependencies. Namely, it will install a new version of arviz which is missing geweke.

I propose to fix this problem by sequentially revising the affected builds to include an upper limit on the arviz version, namely <0.11.2.

This PR is the first step of this process, namely rebuilding v3.8. Here are the relevant changes to meta.yaml for this PR from the original 3.8 version.

maresb commented 3 years ago

The problematic commit to arviz: https://github.com/arviz-devs/arviz/pull/1545

ericmjl commented 3 years ago

Thanks @maresb! Things look good on the CI. I'm going to get one more input from either @OriolAbril or @canyon289 just to make sure things are okay. Though I'm a maintainer on the feedstock, I haven't been involved enough in the day-to-day development of ArviZ to know whether there are hidden warts to look out for.

maresb commented 3 years ago

@ericmjl, sounds good.

Also, in case there are any other outstanding issues with those builds, now may be a good time to address them. :wink:

OriolAbril commented 3 years ago

This is great, thanks! I don't know about any other issues relating those builds, all the posts complaining about geweke on discourse seem to have been solved with that instead of running into other problems

ericmjl commented 3 years ago

Okie dokes, @OriolAbril and @maresb. I'm going to merge, let's see if there are any other issues that crop up!