search

conda-forge / pymc3-feedstock

A conda-smithy repository for pymc3.
BSD 3-Clause "New" or "Revised" License
5 stars 17 forks source link

Rebuild 3.9.2 to fix missing geweke import #57

Closed maresb closed 3 years ago

maresb commented 3 years ago

Checklist

Fixes https://discourse.pymc.io/t/6818

I'd like to rebuild the following versions in order to add arviz<0.11.2 in order to resolve the geweke module problem.

There is a problem with the feedstocks from v3.8 to v3.10.0 inclusive, relating to how pymc3 depends on arviz. The problem is that v0.11.2 of arviz removed arviz.geweke in https://github.com/arviz-devs/arviz/pull/1545. Unfortunately, the aforementioned pymc3 versions import this module on initialization. This means that pymc3 will be completely broken. The command import pymc3 will fail.

Now let's say I run mamba install -c conda-forge pymc3==3.10.10. Then mamba will install that version of pymc3, plus the latest "compatible" versions of its dependencies. Namely, it will install a new version of arviz which is missing geweke.

I propose to fix this problem by sequentially revising the affected builds to include an upper limit on the arviz version, namely <0.11.2.

This PR is the third step of this process, namely rebuilding v3.9.2. Here are the relevant changes to meta.yaml for this PR from the original 3.9.2 version.

I have additionally fixed incorrect minimum versions for python and arviz in the original 3.9.2 feedstock.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

maresb commented 3 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

ericmjl commented 3 years ago

Wonderful work, @maresb! Thanks for taking the time to do this. You'll notice I've been putting the label "automerge" on the PRs. It'll hopefully keep things chugging along smoothly so you don't have to wait for me to merge. I :heart: the automation that conda-forge provides!

github-actions[bot] commented 3 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

maresb commented 3 years ago

Thanks so much @ericmjl!

I believe automerge only applies to PRs from regro-tick-bot. Shall I add myself as maintainer so that I can merge these PRs myself?

ericmjl commented 3 years ago

We'd love to have you on board as a maintainer for the feedstock! Not just for the case of merging PRs on without us :smile: though.

I think, though, automerge has been doing what it's supposed to do -- the past few PRs have been merged without my intervention after I tag the PR with the automerge label.