search

conda-forge / pymc3-feedstock

A conda-smithy repository for pymc3.
BSD 3-Clause "New" or "Revised" License
5 stars 17 forks source link

Rebuild 3.10.0 to fix missing geweke import #60

Closed maresb closed 3 years ago

maresb commented 3 years ago

Checklist

Fixes https://discourse.pymc.io/t/6818

I'd like to rebuild the following versions in order to add arviz<0.11.2 in order to resolve the geweke module problem.

There is a problem with the feedstocks from v3.8 to v3.10.0 inclusive, relating to how pymc3 depends on arviz. The problem is that v0.11.2 of arviz removed arviz.geweke in https://github.com/arviz-devs/arviz/pull/1545. Unfortunately, the aforementioned pymc3 versions import this module on initialization. This means that pymc3 will be completely broken. The command import pymc3 will fail.

Now let's say I run mamba install -c conda-forge pymc3==3.10.10. Then mamba will install that version of pymc3, plus the latest "compatible" versions of its dependencies. Namely, it will install a new version of arviz which is missing geweke.

I propose to fix this problem by sequentially revising the affected builds to include an upper limit on the arviz version, namely <0.11.2.

This PR is the fifth step of this process, namely rebuilding v3.10.0. Here are the relevant changes to meta.yaml for this PR from the original 3.10.0 version.

I have additionally fixed the incorrect minimum versions for python in the original 3.10.0 feedstock.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

maresb commented 3 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

ericmjl commented 3 years ago

This is it, the last one!!!

Already tagged with auto-merge, so we'll be good here, I think, once the CI passes!

Thank you, @maresb for handling this :smile:

maresb commented 3 years ago

Ya, I did see some weird stuff when I tried to build locally with conda mambabuild . though... do you know anything about this error?

ImportError: Version check of the existing lazylinker compiled file. Looking for version 0.211, but found None.

I found this StackOverflow thread about it, but I'm on Linux, not Windows. https://stackoverflow.com/questions/50793797

Let's see what it does on Azure...

As the final step to clean up at the end, we should update meta.yaml to the latest version (with old build number to prevent rebuild).

github-actions[bot] commented 3 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

maresb commented 3 years ago

Ok, I'm feeling quite satisfied with how I left everything. I created a new branch fix-geweke on master and reset master back to the previous commit. Now everything's in a clean state.

Hopefully v3.10.0 is working correctly, I'll test it once it lands on the CDN.

twiecki commented 3 years ago

Thanks so much @maresb!

maresb commented 3 years ago

My pleasure @twiecki, thanks for all the work you do, it's the least I can do for you all!