Add macOS builds - Githubissues

bkpoon commented 2 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@jaimergp I started with your first commit from #8

Maybe version 2.5.0 made things simpler for building on macOS, but the main change is bumping the macOS SDK to 10.12 since that is the minimum supported version for version 2.4+ (https://pymol.org/2/support.html?#installation)

I also had to increase the tolerance for the test since it was failing on linux.

And I tested the Python 3.9 package from the Azure artifact (uploaded to cctbx-dev channel) by loading up a simple model.

Let me know if anything needs to be changed. I want to folllow up with the osx-arm64 build and a Python 3.10 build (pmw migration has not been merged).

Thanks!

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

bkpoon commented 2 years ago

Another note, the deployment target may need to be updated to 10.12 since the source would not compile with the 10.9 SDK (https://conda-forge.org/docs/maintainer/knowledge_base.html#requiring-newer-macos-sdks). I do not have a machine running any macOS earlier than 10.14, so I was not able to check. I can update the deployment target here or wait to see if there are users with issues.

padix-key commented 2 years ago

I do not have a strong opinion on this. As MacOS 10.12 is already 6 years old, I would tend to also increase the target version.

bkpoon commented 2 years ago

I just committed the change to the macOS deployment target. Since Schrödinger lists the minimum to be 10.12, it should be safe to set the minimum here.

bkpoon commented 2 years ago

@conda-forge-admin please rerender

padix-key commented 2 years ago

Thanks again. I would merge this PR, if you are finished with the changes.

bkpoon commented 2 years ago

Yes, I'm done with the changes. I'll add this package to the osx-arm64 migration once this is merged and see what happens. Thanks!

padix-key commented 2 years ago

Before I merge, would you like to be added to the maintainers of this feedstock?

bkpoon commented 2 years ago

@conda-forge-admin please rerender

bkpoon commented 2 years ago

Sure, I would be happy to help.

conda-forge / pymol-open-source-feedstock

Add macOS builds #13