conda-forge / pymysql-feedstock

A conda-smithy repository for pymysql.
BSD 3-Clause "New" or "Revised" License
0 stars 8 forks source link

v1.1.1; switch to github for sdist #17

Closed thewchan closed 2 months ago

thewchan commented 2 months ago

Checklist

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

thewchan commented 2 months ago

@conda-forge-admin, please rerender

thewchan commented 2 months ago

@djsutherland @synapticarbors The bot failed to pick up v1.1.1 because the sdist was only on github. Review and merge appreciated!

synapticarbors commented 2 months ago

Could you do two things:

  1. add a pip check to the tests
  2. update the conda-forge.yml to include:
bot:
  automerge: false
  inspection: update-grayskull

Everything else looks good and I'm happy to merge after. Also thanks for catching this an offering to be a co-maintainer.

thewchan commented 2 months ago

@synapticarbors Done!

github-actions[bot] commented 2 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!