Closed jorisvandenbossche closed 3 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin, please rerender
Hmm, the log output is not giving much clues ..
@jorisvandenbossche thanks for working on this!
I was thinking about trying to setup build & test w/ Github actions to see if that would help identify some of the build issues here (agree: the logs are pretty inscrutible). Was also thinking of looking at the conda recipe for Fiona to see if that yields any hints (unless you've already done so?)
Fiona has a bld.bat script: https://github.com/conda-forge/fiona-feedstock/blob/master/recipe/bld.bat, but, it also has such a similar script for linux. While here that doesn't seem needed?
Of course, fiona's setup.py
is also different, so many potential differences.
@jorisvandenbossche update: I've been working on a CI setup including Windows in this branch. As part of that, I've brought the setup.py and other config closer in line with Fiona (in particular, loading DLLs on Windows with Python >= 3.8 has extra challenges). There were a lot of things that didn't work properly for Windows based on our original setup which likely contributed to failures here.
I'm still debugging why the DLLs load correctly when the module is loaded directly but fail badly when loaded from the tests. Once we have Windows CI tests passing, we can try and make corresponding updates here.
@brendan-ward do you want to cut a new release so we can update this?
@jorisvandenbossche Just added a new release: https://github.com/brendan-ward/pyogrio/releases/tag/v0.2.0
Thanks for the help here!
@conda-forge-admin, please rerender
@brendan-ward thanks! I added an sdist to the release, and updating the PR
The latest edit gave green builds! (not fully sure why it is needed here, though ..)
Going to merge this, so we have packages for the 0.2.0 release, and we can test the windows packages in practice
Thank you so much @jorisvandenbossche for getting this working for Windows! 👏
See https://github.com/conda-forge/pyogrio-feedstock/issues/6
I don't have windows myself, so can't debug this locally, but just to see what it already gives here on CI.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)