pyorc v0.8.0 - Githubissues

regro-cf-autotick-bot commented 1 year ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

[ ] Dependencies have been updated if changed: see upstream
[ ] Tests have passed
[ ] Updated license if changed and license_file is packaged

Information about this PR:

Feel free to push to the bot's branch to update this PR if needed.
The bot will almost always only open one PR per version.
The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

pybind11

_{This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3504080213, please use this URL for debugging.}

Closes https://github.com/conda-forge/pyorc-feedstock/pull/30 Closes https://github.com/conda-forge/pyorc-feedstock/pull/31

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

galipremsagar commented 1 year ago

@conda-forge-linter rerender

github-actions[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pyorc-feedstock/actions/runs/3616949097.

github-actions[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pyorc-feedstock/actions/runs/3616949516.

jakirkham commented 1 year ago

@noirello, think this is trying to build the ORC library as part of the Python build instead of using the libraries from the orc package already supplied. Is there a way to change the build process so pyorc uses the libraries from orc?

Edit: Actually think it is these libraries getting linked to the extension module. We can skip those when ORC is already built IIUC.

jakirkham commented 1 year ago

Looks like we are now seeing a segfault during testing on CI (also attached log for posterity).

noirello commented 1 year ago

@jakirkham Thank you for driving this. There are a couple things that made the conda-forge build difficult and I hadn't got the time to look into it thoroughly.

One of the reason this build is breaking, that the zlib library somehow went AWOL on the linux cpython builds since this PR, and no longer possible to link to the module. The zlib package is listed in the list of conda dependencies, I had no issues linking it previously, I don't know what happened there.

While looking a little bit into it, turned out that it's unnecessary to link the zlib library to the module. That's why I added the extra env var config recently, but linking only the orc library isn't enough (or at least to the non-conda version of the module which builds the ORC lib itself). For example the protobuf symbols are missing from the module's .so file during test. I'm quite confused which symbols are statically included in the orc library and which are not.

The segfault issue is related to ORC-1288, fixed in the recently released ORC 1.8.1, so we have to wait on that conda release.

jakirkham commented 1 year ago

Ah ok. Thanks for all the context! 🙏

With zlib, a libzlib shared library was split out ( https://github.com/conda-forge/zlib-feedstock/pull/52 ). Though this happened a while ago. Not sure why the impact to this feedstock was so delayed.

Though as you say, these libraries shouldn't be needed here.

Interesting would be curious to know what the protobuf issue was. Do you have a reproducer? In any event, doesn't seem to be coming up for the feedstock so far.

Yeah looks like the orc update 1.8.1 just got added with PR ( https://github.com/conda-forge/orc-feedstock/pull/52 ). Asking for a review there. This is now merged and packages are up.

Also we may need a migrator given the tight orc pinning. Though the bot should open a migrator ~~once orc version 1.8.1 is packaged~~ soon.

Anyways hopefully we should get this unstuck soon.

galipremsagar commented 1 year ago

@conda-forge-linter rerender

github-actions[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pyorc-feedstock/actions/runs/3653566430.

jakirkham commented 1 year ago

Think we need an orc 1.8.1 migrator ( like PR https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/3373 ) to proceed