search

conda-forge / pyproj-feedstock

A conda-smithy repository for pyproj.
BSD 3-Clause "New" or "Revised" License
2 stars 15 forks source link

Update branch for 3.2.1 #117

Closed pkgw closed 2 years ago

pkgw commented 2 years ago

This PR is really more of a proposal, to create a new branch for version 3.2.1 of pyproj.

As of 3.3.x, pyproj no longer supports Python 3.7. This means that the py37 packages are getting out of date with regards to evolving dependency pins, especially the bump to proj 9. For instance, sensormapgeo can't pull in the newest fontconfig on Python 3.7 because pyproj ends up sticking it with old versions of geos, gdal, etc.

I can't create a PR that proposes creating another branch, but the idea would be to turn this PR into a new branch so that the 3.2.1 builds can be rebuilt when pinnings change, at least as long as there are dependent packages that want to maintain support for Python 3.7. I revert the most recent changes to bump to the 3.3.x series, rather than forking the branch off from the last commits to support 3.2.x, to keep some of the migrations that have come in since then.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

snowman2 commented 2 years ago

conda-forge will likely drop support for python 3.7 soon because it loosely follows the numpy deprecation policy NEP-29.

snowman2 commented 2 years ago

Is there a reason you cannot upgrade to Python 3.8?

pkgw commented 2 years ago

There are feedstock maintainers who wish to support 3.7 for a little while longer, as best they can. I'm not familiar with the details of their use cases but I'm deferring to their judgment here. That being said, with conda-forge's policy I don't think anyone should expect anything better than best-effort support for 3.7 from here on out.

dopplershift commented 2 years ago

I'm trying to clarify what exactly conda-forge's plans for 3.7 (and really beyond) are in conda-forge/conda-forge-pinning-feedstock#2623.

martinfleis commented 2 years ago

Based on the discussions linked above, it seems that Python 3.7 will stay a bit longer. I'd like to see this branch to happen as it would resolve CI failures popping up across the geopandas ecosystem testing on Python 3.7. Otherwise we would be forced to drop support for Python 3.7 on macOS as it would become complicated to create a working environment without very specific pins of dependencies of dependencies (i.e. pinning pyproj doesn't help, we would need to pin fontconfig).

dopplershift commented 2 years ago

I just created the v3.2.1 branch, so I'd say go ahead.

pkgw commented 2 years ago

Thanks! I've updated this PR to target the 3.2.1 branch.