search

conda-forge / pyproj-feedstock

A conda-smithy repository for pyproj.
BSD 3-Clause "New" or "Revised" License
2 stars 15 forks source link

Rebuild for proj910 #122

Closed regro-cf-autotick-bot closed 2 years ago

regro-cf-autotick-bot commented 2 years ago

This PR has been triggered in an effort to update proj910.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3002051153, please use this URL for debugging.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

snowman2 commented 2 years ago

I recommend waiting for the pyproj 3.4 release. I plan on making a release candidate soon.

snowman2 commented 2 years ago

The minimum supported PROJ version is 8.2 (https://github.com/pyproj4/pyproj/issues/1011) for this release. What is the recommended approach to update the pin?

xylar commented 2 years ago

The minimum supported PROJ version is 8.2 (https://github.com/pyproj4/pyproj/issues/1011) for this release. What is the recommended approach to update the pin?

I don't think there's anything to do. We build with one specific version of proj and that same version is required at runtime: https://github.com/conda-forge/proj.4-feedstock/blob/main/recipe/meta.yaml#L18 So this build will only support PROJ 9.1.0. We would have to make a separate build of pyproj 3.4.0 to support any other proj version.

xylar commented 2 years ago

@snowman2, sorry, what I told you is totally incorrect. We currently build for older proj, too: https://github.com/conda-forge/pyproj-feedstock/blob/main/recipe/conda_build_config.yaml#L2-L3

xylar commented 2 years ago

Based on this comment https://github.com/conda-forge/pyproj-feedstock/pull/96#discussion_r652099081, we should just remove old proj.

xylar commented 2 years ago

@conda-forge-admin, please rerender

xylar commented 2 years ago

@snowman2, I actually think it might be better to build v3.4.0 first with proj 9.0.1 and then migrate to proj 9.1.0. Does that sound reasonable?

snowman2 commented 2 years ago

@snowman2, I actually think it might be better to build v3.4.0 first with proj 9.0.1 and then migrate to proj 9.1.0. Does that sound reasonable?

Sounds good to me :+1:

xylar commented 2 years ago

@conda-forge-admin, please rerender

xylar commented 2 years ago

Okay, this one is rebased and looks clean to me.

github-actions[bot] commented 2 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!