Re-add pypy - Githubissues

conda-forge / pyproj-feedstock

A conda-smithy repository for pyproj.

BSD 3-Clause "New" or "Revised" License

2 stars 15 forks source link

Re-add pypy #146

Closed zklaus closed 8 months ago

zklaus commented 8 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] ~Reset the build number to 0 (if the version changed)~
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 8 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

zklaus commented 8 months ago

From @xylar in https://github.com/conda-forge/pyproj-feedstock/pull/144#issuecomment-1774879076:

I'll setup the pypy-reenable-pr next.

@zklaus, that would be great! I did a little poking around but couldn't figure out what is causing the line:

/etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem /etc/pki/tls/certs

to be prepended to data received by pyproj sync for PyPy, and what would have caused this to change since the last successful PyPY build. Perhaps you have more experience with this kind of thing or will have better luck investigating than I did.

zklaus commented 8 months ago

From @mattip in https://github.com/conda-forge/pyproj-feedstock/pull/144#issuecomment-1774900700:

Is there any stdout parsing going on in processing that command? PyPy had a bug in the last release where debug cruft is printed out in _ssl. I started a new pypy feedstock build conda-forge/pypy3.6-feedstock#112 to clean that up.

xylar commented 8 months ago

Is there any stdout parsing going on in processing that command? PyPy had a bug in the last release where debug cruft is printed out in _ssl. I started a new pypy feedstock build https://github.com/conda-forge/pypy3.6-feedstock/pull/112 to clean that up.

@mattip, oh thanks so much! That's definitely it!

zklaus commented 8 months ago

Sounds promising. Let's restart the CI once conda-forge/pypy3.6-feedstock#112 is in.

xylar commented 8 months ago

Okay, progress but we still need PyPy to be built with ppc64le and aarch64 including the fix, as mentioned in https://github.com/conda-forge/pypy3.6-feedstock/pull/112#issuecomment-1775038759

xylar commented 8 months ago

@conda-forge-admin, please rerender

github-actions[bot] commented 8 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pyproj-feedstock/actions/runs/6768951303.

zklaus commented 8 months ago

Thanks for persisting, @xylar! Does this look good to you? It does look good to me.

xylar commented 8 months ago

Yes, looks great!