conda-forge / pypy3.6-feedstock

A conda-smithy repository for pypy3.6.
BSD 3-Clause "New" or "Revised" License
4 stars 13 forks source link

V7.3.13 #110

Closed mattip closed 1 year ago

mattip commented 1 year ago

Checklist

Fixes #109 (tested by creating an environment with 7.3.12, installing pandas, reproducing the failure. Then substituting the libpypy3.9-c.so with the one from this build and checking that the failure is gone).

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mattip commented 1 year ago

Windows is failing with

ModuleNotFoundError: No module named 'tzdata'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "D:\bld\pypy3.9_1695978865364\_test_env\Lib\zoneinfo\_zoneinfo.py", line 43, in __new__
    instance = cls._weak_cache.setdefault(key, cls._new_instance(key))
  File "D:\bld\pypy3.9_1695978865364\_test_env\Lib\zoneinfo\_zoneinfo.py", line 70, in _new_instance
    file_obj = _common.load_tzdata(key)
  File "D:\bld\pypy3.9_1695978865364\_test_env\Lib\zoneinfo\_common.py", line 24, in load_tzdata
    raise ZoneInfoNotFoundError(f"No time zone found with key {key}")
zoneinfo._common.ZoneInfoNotFoundError: 'No time zone found with key America/Los_Angeles'

It was similarly failing in #108. Is this something that should be skipped on windows?

mattip commented 1 year ago

Ahh, I removed too much from meta.yaml

mattip commented 1 year ago

Note to self: merging this will require an additional PR to https://github.com/conda-forge/pypy-meta-feedstock for 7.3.13, like https://github.com/conda-forge/pypy-meta-feedstock/pull/30

h-vetinari commented 1 year ago

merging this will require an additional PR

For completeness: merging here is fine (actually, a prerequisite); the pypy-meta PR is just necessary so that 7.3.13 is generally available.

mattip commented 1 year ago

Self merging to move this forward