V7.3.8 - Githubissues

conda-forge / pypy3.6-feedstock

A conda-smithy repository for pypy3.6.

BSD 3-Clause "New" or "Revised" License

4 stars 13 forks source link

V7.3.8 #73

Closed mattip closed 2 years ago

mattip commented 2 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Update for PyPy7.3.8:

drop python3.7
update python3.8
add python3.9

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

h-vetinari commented 2 years ago

Great to see this! :)

There's a bunch of patches that are version-guarded and probably need to be "unlocked" for pypy 3.9, e.g.:

      - patches/0018-Disable-copying-dlls.patch  # [name_suffix == "3.7"]
      - patches/0019-Disable-copying-dlls.patch  # [name_suffix == "3.8"]
      - patches/0021-Adapt-platform-to-patch-0001.patch
      - patches/0022-Fix-LIBDIR.patch  # [name_suffix == "3.7"]
      - patches/0023-Fix-LIBDIR.patch  # [name_suffix == "3.8"]

mattip commented 2 years ago

Something strange is happening on windows. The copy a*.lib b.lib is only partially copying the file.

(%BUILD_PREFIX%) %SRC_DIR%\usession-pypy3-0\testing_1>copy *.lib %SRC_DIR%\pypy3\libs\python38.lib   || exit /b 11 
libpypy3-c.lib
        1 file(s) copied.

(%BUILD_PREFIX%) %SRC_DIR%\usession-pypy3-0\testing_1>REM how big is the lib? It should be about 200k 

(%BUILD_PREFIX%) %SRC_DIR%\usession-pypy3-0\testing_1>dir *.lib 
 Volume in drive D is Temporary Storage
 Volume Serial Number is 3A31-7486

 Directory of %SRC_DIR%\usession-pypy3-0\testing_1

02/21/2022  09:19 AM           210,038 libpypy3-c.lib
               1 File(s)        210,038 bytes
               0 Dir(s)  11,379,363,840 bytes free

(%BUILD_PREFIX%) %SRC_DIR%\usession-pypy3-0\testing_1>dir %SRC_DIR%\pypy3\libs\python38.lib 
 Volume in drive D is Temporary Storage
 Volume Serial Number is 3A31-7486

 Directory of %SRC_DIR%\pypy3\libs

02/21/2022  09:19 AM               648 python38.lib
               1 File(s)            648 bytes
               0 Dir(s)  11,379,363,840 bytes free

mattip commented 2 years ago

Got it: copy should use the /b switch: copy /b src target. I don't know why this didn't come up before. Maybe because there is a wild-card * in the src but not in the target

mattip commented 2 years ago

All CI is green. @isuruf could you take a look?

mattip commented 2 years ago

In order to make tox testing work, I think we need the fix for the venv inside a venv issue. I will add a patch.

mattip commented 2 years ago

Patch added, CI is still green. Anyone care to take a look?

isuruf commented 2 years ago

I've started 4 builds each on the ppc64le and aarch64 server. Will take a day for these to get built.

mattip commented 2 years ago

cool, thanks. So I won't do it :100:

h-vetinari commented 2 years ago

Not sure if spurious or whether something changed since the CI ran on this PR, but osx_64_name_suffix3.8openssl1.1.1 failed with an AssertionError during translation after this was merged to master.

h-vetinari commented 2 years ago

Seems that the error should be resolvable by a restart; at least #74 doesn't seem to run into the same problem.