make object.h closer to CPython, fix scratch register issue in the JIT on windows

conda-forge / pypy3.6-feedstock

A conda-smithy repository for pypy3.6.

BSD 3-Clause "New" or "Revised" License

4 stars 13 forks source link

make object.h closer to CPython, fix scratch register issue in the JIT on windows #85

Closed mattip closed 2 years ago

mattip commented 2 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Closes #84

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mattip commented 2 years ago

@conda-forge-admin, please rerender

mattip commented 2 years ago

Hmm. ssl is failing test_wrong_cert_tls13 on macOSX with openssl1.1.1. I don't remember that from upstream. In the mean time upstream fixed a bug with the hashes available in hashlib but I think it is not connected.

mattip commented 2 years ago

Hmm. ssl is failing test_wrong_cert_tls13 on macOSX with openssl1.1.1. I don't remember that from upstream, and a local build of the recipe on a m1 mini using rosetta passes. Is there a way to restart the failing builds?

h-vetinari commented 2 years ago

Is there a way to restart the failing builds?

Seems that you (or someone else) did this already. If you click on "Details" for one of the azure jobs, there's a button on the left to restart the failed jobs. And you can always just comment [at]conda-forge-admin, please restart ci (replace [at]->@).

mattip commented 2 years ago

Cool, now CI is passing. Anyone want to review and/or merge?

mattip commented 2 years ago

Merged, I wonder if it helps conda-forge/scipy-feedstock#204

h-vetinari commented 2 years ago

Merged, I wonder if it helps conda-forge/scipy-feedstock#204

I really expect it to! :)

mattip commented 2 years ago

I forgot how to make aarch64 builds of PyPy. @isuruf it is something about building on a different machine, correct?

h-vetinari commented 2 years ago

If you check his profile, you'll see that Isuru's been gone completely for more than a month. He does have a tweet during that time though, so I think he's just focussing on something else right now (as opposed to some accident, which I truly hope didn't happen). Might have to reach out through a different channel if you really need something from him.

mattip commented 2 years ago

I followed the directions from the last time and did the aarch64 builds. Here is the log logs.txt The artifacts are the new files in these links. https://anaconda.org/mattip/pypy3.9/files and https://anaconda.org/mattip/pypy3.8/files

Could one of the conda-forge admins here upload them to https://anaconda.org/conda-forge/pypy3.9/files and https://anaconda.org/conda-forge/pypy3.8/files respectively?