Closed mattip closed 1 year ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin, please rerender
CI is passing. Anyone care to review?
Ah, and I was wondering about osx-arm support - it's mentioned in the announcement, but I guess it makes sense to tackle this in a separate PR. Or is cross-compilation still a ways away?
it makes sense to tackle this in a separate PR
I think so. I don't know if cross-compilation is an option since it will be very slow. I already build aarch64 and ppc64le outside CI, I could do the same for arm64. However I would want buy-in from the conda-forge team, since it would mean starting a migration for binary packages.
it makes sense to tackle this in a separate PR
xref #88
I don't know if cross-compilation is an option since it will be very slow
Why should it be slow? For aarch/ppc the compilation essentially runs with native (=host) speed. What's slow is emulating one arch through another (e.g. pretend you're aarch64 while running on actual x64 hardware).
But yeah, it would need a new migration (like for pypy-windows at the time), and likely a bunch of effort to get the bootstrap and the first couple of key packages off the ground.
I think I was confused. cross-compilation (using a different compiler chain and tricking python platform
, sys
, os
, sysconfig
and other modules) is not tested and probably will not work out-of-the-box with the PyPy builds. Using qemu on x86 to emulate arm64 will be slow, which is why we build the aarch64 and ppc64le outside of CI.
This should be patched for issue 3865 so the macos-x86_64 will run on older macos<11. The patch is this commit
@mattip Could you upgrade to 7.3.11 here?
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Could you upgrade to 7.3.11 here?
Done
This should be patched for issue 3865
Also done, this was the main reason for v7.3.11
CPython released security fixes for python3.8.16, python3.9.16, it may be worthwhile adding patches for those.
Also done :)
CI is passing.
Once this is merged I will build the ppc64le and aarch64 artifacts outside of CI according to this gist
I think this is ready, no?
It has been a week. If no other reviewer does so before, I will merge soon and then create the other artifacts.
When trying to follow the procedure to build for aarnch64 and ppc64le I am hitting an error when rerendering.
pkg_resources.extern.packaging.version.InvalidVersion: Invalid version: '3.8.* *_cpython'
The error above is on aarch64. On ppc64le that error is a warning.
Starting over from an updated base environment seems to have allowed the build process to complete.
@isuruf the conda-forge-p8-1 machine is out of disk space. Is there a way to clean up something there or to get a larger disk?
@beckermr do you known anything about the ppc64le conda-forge-p8-1 machine? It does not have enough disk space to allow me to build the ppc64le packages for this feedstock, as I have been able to do in the past following this gist. The builds are too slow to use a cross-compilation workflow.
Cleaned up the VM. Have a look now.
I uploaded ppc64le and aarch64 tarballs to https://anaconda.org/mattip/pypy3.8/files and https://anaconda.org/mattip/pypy3.9/files and marked them with the "copy" label. There should be 4 files in each location.
Here are the build logs
ppc64le-logs.txt aarch64-logs.txt
xref @isuruf could you copy the files to https://anaconda.org/conda-forge/pypy3.8 and https://anaconda.org/conda-forge/pypy3.9 ?
Done
Thanks!
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)Part 1 of #98. Note that in the mean time CPython released security fixes for python3.8.16, python3.9.16, it may be worthwhile adding patches for those.