conda-forge / pyqt-feedstock

A conda-smithy repository for pyqt.
BSD 3-Clause "New" or "Revised" License
5 stars 36 forks source link

Rebuild for python310 #105

Closed regro-cf-autotick-bot closed 2 years ago

regro-cf-autotick-bot commented 2 years ago

This PR has been triggered in an effort to update python310.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1443748256, please use this URL for debugging

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

h-vetinari commented 2 years ago

104 is further along...

isuruf commented 2 years ago

@conda-forge-admin, rerender

h-vetinari commented 2 years ago

Cherry-picked the last two commits into #104.

h-vetinari commented 2 years ago

Is there a reason to continue iterating here instead of in #104?

isuruf commented 2 years ago

well, because it seemed like you were in a hurry.

h-vetinari commented 2 years ago

well, because it seemed like you were in a hurry.

I'm not - the only thing is that I myself am not able to debug the cross-compilation (in a reasonable amount of time). I'm more than happy to have you push into my PR (and do trivial debugging myself) if you think the cross-compilation is not far off. What I wanted to avoid is you finishing this and the fixes in my PR falling under the table.

That said, if you're fine to merge #104 and we work on a cc-PR on top, that's completely fine for me as well.

isuruf commented 2 years ago

Can you push the commits to #104 then?

h-vetinari commented 2 years ago

Can you push the commits to #104 then?

Saw this now; done