conda-forge / pyqt-feedstock

A conda-smithy repository for pyqt.
BSD 3-Clause "New" or "Revised" License
5 stars 36 forks source link

Windows: Overwrite configure.py-modified __init__.py with original #139

Open ryanvolz opened 1 month ago

ryanvolz commented 1 month ago

Checklist

Fixes #138.

On Windows, __init__.py is modified by configure.py to find the first directory on the user's PATH that includes Qt5Core.dll and add it to the DLL search paths with os.add_dll_directory(). Conda-forge's qt-main does not distribute Qt5Core.dll, instead calling it Qt5Core_conda.dll, so this modification only serves to allow for external Qt installations to interfere with the conda one in certain situations. This removes that modification since it is at best not needed and at worst introduces bugs.

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ryanvolz commented 1 month ago

Could use some help at this point with the build errors that should be unrelated to the change proposed here.