Open ryanvolz opened 1 month ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:
MACOSX_DEPLOYMENT_TARGET
, to c_stdlib_version
!Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Could use some help at this point with the build errors that should be unrelated to the change proposed here.
Checklist
0
(if the version changed)~conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)Fixes #138.
On Windows,
__init__.py
is modified byconfigure.py
to find the first directory on the user'sPATH
that includesQt5Core.dll
and add it to the DLL search paths withos.add_dll_directory()
. Conda-forge's qt-main does not distributeQt5Core.dll
, instead calling itQt5Core_conda.dll
, so this modification only serves to allow for external Qt installations to interfere with the conda one in certain situations. This removes that modification since it is at best not needed and at worst introduces bugs.