search

conda-forge / pyqt-feedstock

A conda-smithy repository for pyqt.
BSD 3-Clause "New" or "Revised" License
5 stars 35 forks source link

Bump build number #33

Closed jschueller closed 6 years ago

jschueller commented 6 years ago

Rebuilding pyqt locally makes a crash go away with pyfmi. It should be due to the last update of the pinnings of qt.

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jschueller commented 6 years ago

@conda-forge-admin, please rerender

jschueller commented 6 years ago

Need to depend on gcc/libgcc to be able to link the webkit module, I guess qt was not built using the container's gcc:

_placeho/lib/libQt5WebKit.so: undefined reference to `std::__detail::_List_node_base::_M_hook(std::__detail::_List_node_base*)@GLIBCXX_3.4.15'
jschueller commented 6 years ago

Hello, tests pass, can someone from @conda-forge/core merge this ? Also #30, #31 can be closed.

scopatz commented 6 years ago

It would be best if one of the maintainers closes it.

CJ-Wright commented 6 years ago

@conda-forge/pyqt

mingwandroid commented 6 years ago

It's Qt that needs to depend upon libgcc here though?

ccordoba12 commented 6 years ago

Merging, sorry for the delay.

mingwandroid commented 6 years ago

I don't think this should have been merged at least not based on the stated issue since lib/libQt5WebKit.so is a part of the Qt package not the pyqt package.

Or at least, libgcc should be added to the qt dependencies and it should be repackaged and re-uploaded.

ccordoba12 commented 6 years ago

Sorry Ray, I didn't see your comment before merging. This can be reverted once someone creates a new build for Qt. In the meantime, I don't think it's a bad workaround.

mingwandroid commented 6 years ago

OK fair enough.

kmuehlbauer commented 6 years ago

@conda-forge/pyqt

Since this change the packages (in my case):

libgcc:       7.2.0-h69d50b8_2
libgcc-ng:    7.2.0-hdf63c60_3
libstdcxx-ng: 7.2.0-hdf63c60_3

from defaults are installed into the environment when pyqt is installed (eg.as dependecy of matplotlib). Is this wanted behaviour? I'm just curious, because the other days these packages where not needed. Is there anything to read how conda-forge handles the use of packages from defaults?