search

conda-forge / pyqt-feedstock

A conda-smithy repository for pyqt.
BSD 3-Clause "New" or "Revised" License
5 stars 36 forks source link

Rebuild for Python 3.7, GCC 7, R 3.5.1, openBLAS 0.3.2 #41

Closed regro-cf-autotick-bot closed 5 years ago

regro-cf-autotick-bot commented 5 years ago

It is likely this feedstock needs to be rebuilt. Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children: enaml glue-core glue-vispy-viewers hyperspy-gui-traitsui instaseis And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one.

This PR was created by the cf-regro-autotick-bot. The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues!

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

grlee77 commented 5 years ago

Now the build completed on linux, but there is a failure on import of PyQt5.QtOpenGL for the gcc7 cases. from the test section of the log

ModuleNotFoundError: No module named 'PyQt5.QtOpenGL'

and earlier during the build:

Checking to see if the QtOpenGL module should be built...
/home/conda/feedstock_root/build_artifacts/pyqt_1542329934029/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/bin/qmake -o cfgtest_QtOpenGL.mk cfgtest_QtOpenGL.pro
Project ERROR: Unknown module(s) in QT: opengl
looooo commented 5 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

looooo commented 5 years ago

can any maintainer of this feedstock restart the failing builds? qt5.6 from conda-forge is now build with opengl enabled.

grlee77 commented 5 years ago

@looooo , there is now an OpenGL-related linking error during the linux gcc builds:

x86_64-conda_cos6-linux-gnu-c++ -Wl,-O2 -Wl,--sort-common -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,--disable-new-dtags -Wl,-rpath,$PREFIX/lib -L$PREFIX/lib -Wl,-rpath-link,$PREFIX/lib -Wl,-rpath-link,/home/conda/feedstock_root/build_artifacts/qt_1542565944096/_build_env/x86_64-conda_cos6-linux-gnu/sysroot -Wl,-O1 -Wl,-rpath,$PREFIX/lib -o cfgtest_QtGui cfgtest_QtGui.o   -L$PREFIX/lib -lQt5Gui -lQt5Core -lGL -lpthread 
$BUILD_PREFIX/bin/../lib/gcc/x86_64-conda_cos6-linux-gnu/7.3.0/../../../../x86_64-conda_cos6-linux-gnu/bin/ld: cannot find -lGL
collect2: error: ld returned 1 exit status
make: *** [cfgtest_QtGui] Error 1

Do we need to add some or all of these CDT packages under build as in the Qt recipe?: https://github.com/conda-forge/qt-feedstock/blob/a9c82fb1d90830f8b648ee4186ef66db5056e852/recipe/meta.yaml#L35-L40

What does CDT stand for anyway? I am not familiar with the acronym.

looooo commented 5 years ago

What does CDT stand for anyway? I am not familiar with the acronym.

Yes I am also wondering about the naming for some time. You can find a little bit of information here

Do we need to add some or all of these CDT packages under host as in the Qt recipe?:

For another qt-dependent feedstock I added quite a few of these cdt's to make it work. So yes I think these should be added. But maybe someone more familiar with cdt's can help here. @mingwandroid

mingwandroid commented 5 years ago

We may want to think about something like build_exports whereby qt adds build dependencies for CDT packages. Thoughts welcome!

grlee77 commented 5 years ago

A made a PR including the CDT packages (see #42) and it built successfully.

ccordoba12 commented 5 years ago

Ok, thanks! Closing this one then.