search

conda-forge / pyqt-feedstock

A conda-smithy repository for pyqt.
BSD 3-Clause "New" or "Revised" License
5 stars 36 forks source link

Trigger rebuild to have QtWebKitWidgets in macOS #43

Closed ccordoba12 closed 5 years ago

ccordoba12 commented 5 years ago

Checklist

This triggers a necessary rebuild after https://github.com/conda-forge/qt-feedstock/pull/82 and https://github.com/conda-forge/sip-feedstock/pull/12

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ccordoba12 commented 5 years ago

@conda-forge-admin, please rerender

jakirkham commented 5 years ago

It seems to be using the wrong SDK on macOS. 😕

ld: in '/Applications/Xcode-9.4.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks//ColorSync.framework/Versions/A/ColorSync.tbd', file was built for unsupported file format ( 0x2D 0x2D 0x2D 0x20 0x21 0x74 0x61 0x70 0x69 0x2D 0x74 0x62 0x64 0x2D 0x76 0x33 ) which is not the architecture being linked (x86_64): /Applications/Xcode-9.4.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks//ColorSync.framework/Versions/A/ColorSync.tbd for architecture x86_64
clang-4.0: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [cfgtest_QtTest.app/Contents/MacOS/cfgtest_QtTest] Error 1

ref: https://travis-ci.org/conda-forge/pyqt-feedstock/jobs/469176172

ccordoba12 commented 5 years ago

I set MACOSX_DEPLOYMENT_TARGET to see if that fixes the problem.

I think the problem is in the xcode image used by Travis.

ccordoba12 commented 5 years ago

Ok, my last commit solved the problem but I still have to recompile sip. That's because the sip version compatible with the current version of PyQt has not yet been generated with the new compilers.

So please DON'T merge this one yet.

jakirkham commented 5 years ago

Could you please raise an issue on conda-smithy about the macOS error? I think we will want to do more digging into that. Especially since the xcode6.4 image will be retired soon. ( https://github.com/conda-forge/conda-forge.github.io/issues/641 )

isuruf commented 5 years ago

Last commit was not a fix. It just hides the error and uses 10.10, but we want 10.9

ccordoba12 commented 5 years ago

Ok, let's call it a workaround. However, it's using the exact same Travis setup that was working before and that people confirmed is creating correct packages.

I really don't have time to make things work with XCode 9.4, sorry.

jakirkham commented 5 years ago

@isuruf, there may be other issues as well (a link to the relevant log lines you are looking at would be helpful). That said, the macOS 10.13 image is actually causing the build problems. Namely it is making use of TBD files, which the new toolchain does not currently support. More details in this comment.