search

conda-forge / pyqt-feedstock

A conda-smithy repository for pyqt.
BSD 3-Clause "New" or "Revised" License
5 stars 36 forks source link

Dropping gtk2-devel from yum_requirements.txt #47

Closed jakirkham closed 5 years ago

jakirkham commented 5 years ago

As qt already requires gtk2 from conda-forge, there shouldn't be a need to install gtk2-devel with yum.

If pyqt is linking to gtk2 directly, it probably is linking to the conda-forge package and then should list it as a dependency. Though this last part would need to be checked.

mingwandroid commented 5 years ago

This is a huge dependency just to get sympathetic window styling in QStyle. I'd remove it personally.

jakirkham commented 5 years ago

If you'd like to discuss that, feel free to, but this would be a discussion at the qt feedstock given that is where this change has already occurred.

ccordoba12 commented 5 years ago

@mingwandroid, it's only needed at build time, if I remember correctly.

jakirkham commented 5 years ago

Currently it is listed as a run dependency as well. Am I understanding you correctly that this shouldn't be the case? If so, would you be willing to raise an issue over at the qt feedstock?

ocefpaf commented 5 years ago

We should either keep the yum_requirements.txt or use a CTD (we are doing both on qt BTW due to lack of time to test-debug which one works).

Here I believe we added it to get the tests passing but agree with @mingwandroid, I'm :-1: to add it as an actual requirement. Closing this.