search

conda-forge / pyqt-feedstock

A conda-smithy repository for pyqt.
BSD 3-Clause "New" or "Revised" License
5 stars 36 forks source link

Rebuild for qt-5.9.7 #50

Closed regro-cf-autotick-bot closed 5 years ago

regro-cf-autotick-bot commented 5 years ago

This PR has been triggered in an effort to update qt-5.9.7.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed. Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children: ggplot mss qgis qscintilla2 ovito And potentially more. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one.

This PR was created by the cf-regro-autotick-bot. The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues!

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ocefpaf commented 5 years ago

We probably need to update this recipe and review the sip pin here. Do not merge this until someone gets a change to do so.

CJ-Wright commented 5 years ago

@conda-forge-admin please rerender

CJ-Wright commented 5 years ago

Does this need pyqt to be bumped to 5.9?

ocefpaf commented 5 years ago

Does this need pyqt to be bumped to 5.9?

Probably good to have even if that is not needed. BTW, what are you doing here? I thought that @scopatz took your rights away! Go back to your studies and come back once you have a PhD!

ccordoba12 commented 5 years ago

Closing this in favor of #51.

ocefpaf commented 5 years ago

@ccordoba12 usually it is better to commit on top of the bot or leave it open until you merge the alternative PR. Otherwise the bot will believe that this is "done" and move to the next package int eh graph.

ccordoba12 commented 5 years ago

Ok, I'll leave it open but I'll keep working on #51 because it's easier.

Update: I'll keep working here.

ocefpaf commented 5 years ago

I don't think reopening works for the bot. It was just a note for future reference.

On Wed, May 1, 2019, 18:00 Carlos Cordoba notifications@github.com wrote:

Reopened #50 https://github.com/conda-forge/pyqt-feedstock/pull/50.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/conda-forge/pyqt-feedstock/pull/50#event-2312873443, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHICL63SAPGI6KPPZ64PXTPTIAINANCNFSM4HIQOS5Q .

ccordoba12 commented 5 years ago

@conda-forge-admin, please rerender

ccordoba12 commented 5 years ago

@ocefpaf, the Windows builds are failing at the very beginning. It would seem that the Qt packages were not compiled correctly?

ocefpaf commented 5 years ago

@ocefpaf, the Windows builds are failing at the very beginning. It would seem that the Qt packages were not compiled correctly?

I have the new packages but I'm at PyCon with limited time to upload them now, I'll upload them ASAP.

ccordoba12 commented 5 years ago

Ok, great to know you have new builds! There's no rush because I still have to figure out why the builds are failing in macOS/Python 3.

@isuruf, do you some insights about that?

ccordoba12 commented 5 years ago

@conda-forge-admin, please rerender

ccordoba12 commented 5 years ago

@conda-forge-admin, please rerender

ccordoba12 commented 5 years ago

@conda-forge-admin, please rerender

ccordoba12 commented 5 years ago

@ocefpaf, thanks for rebuilding the Qt Windows packages! Everything is passing now, except for macOS/Python 3. I have no idea how to fix those though. The error seems like an issue with configure.py, but I haven't seen it before.

My suggestion is to merge this for now and then track this problem in another PR. What do you think?

ocefpaf commented 5 years ago

My suggestion is to merge this for now and then track this problem in another PR. What do you think?

Let's give @mingwandroid and @isuruf a chance to look at it first. The migration is already "broken" downstream and macOS is a pretty important platform to skip.

isuruf commented 5 years ago

Try,

diff --git a/configure.py b/configure.py
index a263efb..115075f 100644
--- a/configure.py
+++ b/configure.py
@@ -943,6 +943,9 @@ class TargetConfiguration:
         Python interpreter library.
         """

+        if self.py_platform == 'darwin':
+            return '-undefined dynamic_lookup'
+
         args = qmake_quote('-L' + self.py_pylib_dir)

         if name:
ccordoba12 commented 5 years ago

Merging because everything is green now. Thanks @isuruf for your help!