FIX: Properly set python shared library to link pyqt plugins.

conda-forge / pyqt-feedstock

A conda-smithy repository for pyqt.

BSD 3-Clause "New" or "Revised" License

5 stars 35 forks source link

Closed hhslepicka closed 5 years ago

hhslepicka commented 5 years ago

Checklist

[X] Used a fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[X] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

The patches used before were just masking the underlying issue that pyqt was not really linking against the Python shared library.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hhslepicka commented 5 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

hhslepicka commented 5 years ago

@ccordoba12 this is good to go! 👍

ccordoba12 commented 5 years ago

@isuruf, could you review this PR? I don't understand very well what @hhslepicka tries to do here for macOS.

hhslepicka commented 5 years ago

@ccordoba12 the patch is for macOS and Linux. Windows assume that it is always shared.

isuruf commented 5 years ago

+1 to merge. Can you delete the unneeded patches?

hhslepicka commented 5 years ago

@isuruf done. Thank you for looking at it again.

isuruf commented 5 years ago

Thanks for the PR

hhslepicka commented 5 years ago

CCE8E4EE-3640-4FC3-9D60-2AB00A048A94 Thanks for merging, @isuruf