conda-forge / pyqt-feedstock

A conda-smithy repository for pyqt.
BSD 3-Clause "New" or "Revised" License
5 stars 35 forks source link

FIX: Properly set pyshlib suffix. #57

Closed hhslepicka closed 5 years ago

hhslepicka commented 5 years ago

Checklist

After merging #54 I noticed that the plugins started to look for libpythonX.Ym.a.PREFIX in which X is the major version, Y is minor and PREFIX is .so for Linux and .dylib for OSX. E.g. libpython3.7m.a.so.

This new PR forces the proper suffix since the one that we fetch from sysconfig provides the wrong shared library name.

Attn. @isuruf

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hhslepicka commented 5 years ago

@conda-forge-admin, please rerender

hhslepicka commented 5 years ago

Just a little more context... If I run the code from configure.py using a anaconda python, I get the proper library prefix but during the CI build process it is not true, which caused the confusion and mistake.

hhslepicka commented 5 years ago

@isuruf @ccordoba12 this is good for a review. Sorry about the mistake and the need to open a new PR to still tackle this problem with the plugin.

isuruf commented 5 years ago

Thanks