conda-forge / pyqt-feedstock

A conda-smithy repository for pyqt.
BSD 3-Clause "New" or "Revised" License
5 stars 36 forks source link

Ensure prefix is picked up on Windows so pyrcc5 runs #63

Closed gillins closed 4 years ago

gillins commented 4 years ago

Checklist

xref: https://github.com/conda-forge/qgis-feedstock/pull/86

In pyqt 5.9, pyrcc5 is now a .bat file. The path to Python is written into it during the build, but because there is no space after the @ symbol (I think) conda-build isn't picking up that this needs to be replaced at install time like it does on Unix.

I've also added a test that pyrcc5 actually runs.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

gillins commented 4 years ago

@conda-forge-admin, please rerender

ocefpaf commented 4 years ago

Thanks @gillins!