search

conda-forge / pyqt-feedstock

A conda-smithy repository for pyqt.
BSD 3-Clause "New" or "Revised" License
5 stars 36 forks source link

Rebuild for pypy #79

Closed regro-cf-autotick-bot closed 4 years ago

regro-cf-autotick-bot commented 4 years ago

This PR has been triggered in an effort to update pypy.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://circleci.com/gh/regro/circle_worker/16449, please use this URL for debugging

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

h-vetinari commented 4 years ago

@conda-forge/help-pypy

Same error as on the previous run of this PR (#76):

AttributeError: module 'distutils.sysconfig' has no attribute 'get_config_h_filename'

This is the biggest bottleneck in the pypy-migration with ~350 directly dependent children.

mattip commented 4 years ago

distutils.sysconfig.get_config_h_filename() does not exist in python3.6. That is a python3.7 addition. Could you change it to sysconfig.get_config_h_filename() which works on both versions?

mattip commented 4 years ago

As far as PyPy support for SIP-related projects: does SIP support other backends like cppyy? I think the C-API will be a performance bottleneck for PyPy.

h-vetinari commented 4 years ago

@mattip: Could you change it to sysconfig.get_config_h_filename() which works on both versions?

As I'm not a maintainer here, this would have to happen in a different PR - I'll wait if someone from @conda-forge/pyqt can pick this up.

As far as PyPy support for SIP-related projects: does SIP support other backends like cppyy? I think the C-API will be a performance bottleneck for PyPy.

No idea. I just came here because I saw that this was the biggest blocker in the pypy-migration currently.

jschueller commented 4 years ago

should be fixed by #80

regro-cf-autotick-bot commented 4 years ago

Due to the bot-rerun label I'm closing this PR. I will make another one as appropriate. This was generated by https://circleci.com/gh/regro/circle_worker/16630