search

conda-forge / pyqt-feedstock

A conda-smithy repository for pyqt.
BSD 3-Clause "New" or "Revised" License
5 stars 35 forks source link

Add PyQt 5.7 wheels binaries #8

Closed hadim closed 7 years ago

hadim commented 7 years ago

Qt 5.7 is unlikely to appear anytime soon in conda-forge. In the meantime could we use the wheels binaries available in PyPi for PyQt 5.7 ?

(only for py35)

@conda-forge-admin

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ccordoba12 commented 7 years ago

I completely disagree with this PR. My reasons:

  1. We can compile binaries from scratch. Conda-forge maintainers agreed to allow certain individuals to create packages and upload them to anaconda.org. For now this is going to start with Qt4, but I hope it'll continue with Qt5 in short time.
  2. PyQt5 wheels have several problems, e.g. spyder-ide/spyder#3520. This is because they are using WebEngine (based on Chromium) as its default web backend. In Continuum we preferred to use WebKit, which is still more stable.
  3. You're not creating a new branch for this change but instead replacing master contents. That's not the way to proceed.

Please allow us (the feedstock maintainers) to do these changes. I know it's frustrating to still not have Qt5/PyQt5 in conda-forge, but it'll arrive, just be patient :-)

ccordoba12 commented 7 years ago

I cancelled the build because of my reasons above. This simply is not going in, sorry.

hadim commented 7 years ago

Just trying to help and move forward...

ccordoba12 commented 7 years ago

Sorry, I understand that :-) After Qt4 packages for conda-forge are all in place, @mingwandroid, @ocefpaf and me will continue with Qt5.

hadim commented 7 years ago

Yes and this PR was just a temporary way to have PyQt 5.7 waiting for a more appropriate solution.

Anyway.

hadim commented 7 years ago

For the second point, there is a lot of projects not using WebEngine/WebKit so once again as a temporary package, this PR is ok.

For the third point, that is easy to fix....

hadim commented 7 years ago

Anyway I give up trying to help here...

ccordoba12 commented 7 years ago

@hadim, this is not the right solution, that's all, sorry.

ocefpaf commented 7 years ago

@hadim a more consistent solution will be implemented soon. I am traveling this week but I plan to upload qt builds as soon possible.

Also, conda-forge is changing its policy regarding repackaging stuff. More on this soon.

BTW your help is valuable, stick around 😉 But the discussion is important too. So have patience and I assure you a better solution will be in place soon.

On Nov 27, 2016 1:52 PM, "Carlos Cordoba" notifications@github.com wrote:

@hadim, this is not the right solution, that's all, sorry.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub, or mute the thread.

hadim commented 7 years ago

@ccordoba12 this is not the correct way to answer, that's all sorry.

@ocefpaf I didn't know about repackaging policy. I can understand that and will wait for a more consistent solution then.

ccordoba12 commented 7 years ago

@ccordoba12 this is not the correct way to answer, that's all sorry.

I don't know what you mean :-/

What I tried to say is that we're not considering your work valuable, just that this PR is not the correct way to address the update to PyQt5 (for the reasons i explained above).

ocefpaf commented 7 years ago

@ccordoba12 this is not the correct way to answer, that's all sorry.

Let's not worry too much. Short and incomplete answers happens.

@ocefpaf I didn't know about repackaging policy. I can understand that and will wait for a more consistent solution then.

No one knows ; -) We are still discussing that. But the goal is to reduce repackaging as much as possible.