Enable QtWinExtras for Windows Build

conda-forge / pyqt-feedstock

A conda-smithy repository for pyqt.

BSD 3-Clause "New" or "Revised" License

5 stars 35 forks source link

Open n-elie opened 4 years ago

n-elie commented 4 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

mingwandroid commented 4 years ago

Did you test this? It doesn't work. There's a typo in QtWinExtas, also you are enabling QtSerialPort in this.

n-elie commented 4 years ago

I was not able to test because pyqt source code is not available at the given adress anymore. Also, QtSerialPort was already enabled.

n-elie commented 4 years ago

Would it be allowed to use archive.org to get the source code?

jschueller commented 4 years ago