ENH use outputs to not confuse conda

beckermr commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

closes #77

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

It looks like the 'pyqt' output doesn't have any tests.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

It looks like the 'pyqt-sip' output doesn't have any tests.
It looks like the 'pyqt' output doesn't have any tests.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

It looks like the 'pyqt-sip' output doesn't have any tests.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

beckermr commented 3 years ago

cc @vrindger

beckermr commented 3 years ago

@conda-forge/pyqt this one is ready for review!

gillins commented 3 years ago

@beckermr do we still need https://github.com/conda-forge/sip-feedstock ? pyqt provides its own sip AFAICT. Now that sip and pyqt are now providing different versions of sip I am seeing some RuntimeError: the sip module implements API v12.0 to v12.6 but the qgis._gui module requires API v12.7 errors when compiling qgis (https://github.com/conda-forge/qgis-feedstock/pull/154) as they both get pulled in.

Am I missing something?

beckermr commented 3 years ago

pyqt always shipped its own sip. I just moved it to another package. So I don't think this error is related.

gillins commented 3 years ago

So I don't think this error is related.

Yes you are right, it is just that recently the versions of sip within the sip package and the one in pyqt have diverged quite a bit (4.19.24 vs 4.12.3) which seems certain to cause problems down the track.

qscintalla2 (and probably other packages) depend on both pyqt and sip. Currently this means any package pulling on qscintilla2 gets 2 copies of sip and what I'm seeing in qgis is that the executable is one version, but the python bindings are another (due to the version mismatch). This seems a bit crazy even if the versions were the same.

I guess what I'm really asking is: should pyqt depend on the sip package rather than bundling its own? Or alternatively we remove the sip package (and update some recipes).

beckermr commented 3 years ago

IDK. Maybe @conda-forge/pyqt can weigh in?

ocefpaf commented 3 years ago

I guess what I'm really asking is: should pyqt depend on the sip package rather than bundling its own? Or alternatively we remove the sip package (and update some recipes).

Ideally we should remove sip from pyqt and we would use our build everywhere. However, at this point, it is probably easier to just not use our sip and updated the other recipes.

gillins commented 3 years ago

However, at this point, it is probably easier to just not use our sip and updated the other recipes.

OK will look into this. Just noticed that qscintilla2 needs a more recent sip than pyqt has (https://github.com/conda-forge/qscintilla2-feedstock/blob/master/recipe/meta.yaml#L52) so maybe first step is to sync the versions...

gillins commented 3 years ago

See https://github.com/conda-forge/pyqt-feedstock/pull/94 - maybe this will be all that is required :crossed_fingers:

conda-forge / pyqt-feedstock

ENH use outputs to not confuse conda #91