Update sip to 4.19.24 to match sip-feedstock

conda-forge / pyqt-feedstock

A conda-smithy repository for pyqt.

BSD 3-Clause "New" or "Revised" License

5 stars 36 forks source link

Update sip to 4.19.24 to match sip-feedstock #94

Closed gillins closed 3 years ago

gillins commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

This is just an update to the sip version to match the sip-feedstock version. Hopefully this will solve the conflicts for projects that end up pulling in both pyqt and sip.

Long term solution may be to use sip-feedstock instead of bundling out own.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

gillins commented 3 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

gillins commented 3 years ago

So maybe we can't build pyqt with a newer sip? Is this a known problem?

ccordoba12 commented 3 years ago

That could be the case because newer versions of sip can break compatibility with older PyQt's. I think that's why sip started to be distributed directly with PyQt instead of as a separate package.

gillins commented 3 years ago

thanks @ccordoba12 that would explain it...