Rebuild with new conda-build

conda-forge / pyqt-feedstock

A conda-smithy repository for pyqt.

BSD 3-Clause "New" or "Revised" License

5 stars 36 forks source link

Rebuild with new conda-build #95

Closed Tobias-Fischer closed 3 years ago

Tobias-Fischer commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Tobias-Fischer commented 3 years ago

@conda-forge-admin, please rerender

Tobias-Fischer commented 3 years ago

I thought this would be an easy one, but something is going wrong. I observed that the Windows SDK tools version shown in the linker error doesn't match the one set earlier in the build - not sure why though:

LINK : fatal error LNK1181: cannot open input file 'C:\Program Files (x86)\Windows Kits\10\lib\10.0.18362.0\um\x64\shell32.lib'

(base) D:\bld\pyqt_split_1610322824354\work>if errorlevel 1 (echo "Didn't find any windows 10 SDK. I'm not sure if things will work, but let's try..." )  else (echo Windows SDK version found as: "10.0.17763.0" ) 
Windows SDK version found as: "10.0.17763.0"

ocefpaf commented 3 years ago

Thanks for the PR, we really need a rebuild of pyqt that "works." But I believe that @isuruf found a problem with this conda-build release and we probably need to wait a bit more. Maybe the problem you are seeing here is unrelated though.

Tobias-Fischer commented 3 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you but ran into some issues, please ping conda-forge/core for further assistance. You can also try re-rendering locally.

isuruf commented 3 years ago

Should be fixed with the latest qt rebuild.

Tobias-Fischer commented 3 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

Tobias-Fischer commented 3 years ago

@conda-forge-admin, please restart ci

isuruf commented 3 years ago

@Tobias-Fischer, why restart CI, when it was already green? https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=261531&view=results

Tobias-Fischer commented 3 years ago

I wasn't sure whether the last QT version was pulled in - sorry for that.

Tobias-Fischer commented 3 years ago

Seems like indeed all builds fine. I think this is ready to be merged @conda-forge/pyqt

gillins commented 3 years ago

Thanks @Tobias-Fischer !

ocefpaf commented 3 years ago

Thanks for fixing this!