Closed hmaarrfk closed 2 years ago
conda-forge-linter
commented
2 years ago Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
hmaarrfk
commented
2 years ago I think I understand why linux is failing. Basically we have to rebuild the shortcuts to the uic and rcc tools.
I don't understand why windows is failing to import shiboken. Maybe it is in the wrong build/host environment.
As for OSX, I think shiboken needs to be installed in the host environemnt (x86) and not (arm) so I'm trying to build out the recipe in my own channel to see how things work:
https://github.com/hmaarrfk/shiboken2-feedstock
looooo
commented
2 years ago this looks promising. Do you know what the status of qt-main 5.15.3 is. For osx_arm it is needed but I it's seems like it is still conflicting with qtwebengine.
hmaarrfk
commented
2 years ago do you mean we need 5.15.3 and not 5.15.2 for osx + arm?
hmaarrfk
commented
2 years ago I'm not sure why windows is failing to import shiboken. I'm going to try to build it out with a separate shiboken package.
I have one ready: https://dev.azure.com/markharfouche0439/feedstocks/_build/results?buildId=51&view=results, i will have to upload it.
hmaarrfk
commented
2 years ago the build logs for shiboken2 i have linked to show the same error as here. it just seems to not like clang for OSX-arm.
hmaarrfk
commented
2 years ago Truthfully, I'm not too sure why you enabled M1 during this update. It requires cross compilation which isn't too easy to handle on a first pass.
It seems Qt made some good progress recently for PySide6, but it is not really trivial to backport such changes.
I might stop before "M1" builds. and let somebody else take those over.
hmaarrfk
commented
2 years ago hmaarrfk
commented
2 years ago @conda-forge-admin please rerender
I think windows is not searching in all the right directories.
looooo
commented
2 years ago @hmaarrfk I tried to compile for osx_arm64 and it worked but then this happened:
[cctools-port]: generating fake signature for '/Users/lo/mambaforge/conda-bld/pyside2_1652985232954/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/libshiboken2.cpython-310-darwin.5.15.3.dylib'
libc++abi: terminating with uncaught exception of type std::runtime_error: codesign_failed: 0i'm not too sure. this seems like it might be related to https://github.com/conda-forge/miniforge/issues/190 @conda-forge/help-osx-arm64
looooo
commented
2 years ago I installed Xcode but I am still running into the same issue with osx_arm.
hmaarrfk
commented
2 years ago is it ok if we leave the architecture migrations out of this one? We can focus on them more cleanly in a subsequent PR. We can likely get them to work on the CI with correct setttings for cross compilation.
hmaarrfk
commented
2 years ago At this stage, it seems that the only thing to do is to copy the entry points correctly for windows.
hmaarrfk
commented
2 years ago sigh, i force pushed, now i only have 1/4 windows builds instead of 3/4.
hmaarrfk
commented
2 years ago Well it seems that I'm missing a few patches for windows and Python 3.8+. However, I'm not sure which one.
I don't know if you have time to take over @looooo but that would be helpful.
building off @looooo 's great work, but I don't want to create needless conflicts with them
https://github.com/conda-forge/pyside2-feedstock/pull/109/
Estimated build time: 90 mins.
Checklist
0(if the version changed)conda-smithy(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)