V5.15.4 - Githubissues

conda-forge / pyside2-feedstock

A conda-smithy repository for pyside2.

BSD 3-Clause "New" or "Revised" License

17 stars 19 forks source link

Closed hmaarrfk closed 2 years ago

hmaarrfk commented 2 years ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 2 years ago

i just can't understand why it is giving this error on 3.8, but not 3.7.

hmaarrfk commented 2 years ago

hmaarrfk commented 2 years ago

seems like it is working!

hmaarrfk commented 2 years ago

The two things I noticed looking at hte logs are:

[ ] Do we need to explicitely depend on ucrt? Windows builds seem to be warning for it.
[ ] How do we actually get the windows tests to work? It seems they all fail due to some inconsistencies with paths.

jan-janssen commented 2 years ago

@hmaarrfk I am happy to merge this whenever you are ready. Great work!

hmaarrfk commented 2 years ago

I think this is working. But I'm just not sure about windows since I don't have too much experience on it

jan-janssen commented 2 years ago

Ok, I merged it and then we just see if some windows users complain.

jan-janssen commented 2 years ago

@hmaarrfk btw. feel free to add yourself to the maintainers.