Fix QToolButton.setMenu not keeping reference of menu

conda-forge / pyside2-feedstock

A conda-smithy repository for pyside2.

BSD 3-Clause "New" or "Revised" License

17 stars 19 forks source link

Fix QToolButton.setMenu not keeping reference of menu #119

Closed n-elie closed 2 years ago

n-elie commented 2 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

n-elie commented 2 years ago

@conda-forge-admin, please rerender

hmaarrfk commented 2 years ago

Sorry for keeping this lingering. Do you have a reference of the upstream issue? It is somewhat problematic to patch things unrelated to the build system without a reference to any issue.

n-elie commented 2 years ago

I found this issue where it seems the behaviour I am trying to fix is intended, to match C++ API: Ownership of the menu is not transferred to the tool button. This is implemented differently in PyQt. Sorry for the noise.