search

conda-forge / pyside2-feedstock

A conda-smithy repository for pyside2.
BSD 3-Clause "New" or "Revised" License
17 stars 19 forks source link

This builds on #114 to get osx-arm64 working #120

Closed bkpoon closed 2 years ago

bkpoon commented 2 years ago

Checklist

This starts with the commits from #114 and fixes the remaining compilation issues 1) There are calls to generate_pyi.py that are using the built shiboken2 and PySide2 packages. I pointed the call to use the packages in $BUILD_PREFIX. The --sys-path argument is used instead of PYTHONPATH since the code seems to overwrites PYTHONPATH. 2) There was a failure during installation about a missing library (libpysidetest.dylib) so I removed the -DBUILD_TESTS=no flag.

I did check the package in the artifact with a PySide2 GUI that I have, but it is not a complete test.

I can update this branch to build with 5.15.5 if someone up can resubmit the migrator. I'll cherry-pick the relevant commits so that all platforms are built and tested. And then someone can merge/rebase this branch into the migrator branch.

@isuruf are some of your changes only applicable to cross-compiling? If so, I can add some if statements.

Let me know if any other changes are needed. Thanks!

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

bkpoon commented 2 years ago

The Azure build is on my organization so you can see the log output there, but I'm not sure why this PR is not starting any builds. https://dev.azure.com/cctbx-release/feedstock-builds/_build/results?buildId=3145&view=results

bkpoon commented 2 years ago

Moved to #122