conda-forge / pyside2-feedstock

A conda-smithy repository for pyside2.
BSD 3-Clause "New" or "Revised" License
17 stars 19 forks source link

Changes to make #121 pass (osx-arm64 builds) #122

Closed bkpoon closed 2 years ago

bkpoon commented 2 years ago

Checklist

This takes commits from #114 and #120 to get the builds to work on osx-arm64.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

bkpoon commented 2 years ago

This adds to the work in #114 and details for my changes are in #120, but essentially, there was a step calling generate_pyi.py that would import the shiboken2 and PySide2 modules that are built. I pointed python to the versions in $BUILD_PREFIX.

I tested the Python 3.9 package in the artifact on a GUI and things seem to work.

However, there is a problem when solving for the build environment since the latest builds of qt-main require libclang=14 which conflicts with the currently pinned compiler version. I pinned the pyside2 dependency in build to 15.5.4 so that an earlier version of qt-main is used. An earlier build of this version uses libclang=13 which allows the build environment to be solved.

I am not sure if this is the best solution, so any suggestions are welcome. And let me know if any other changes are needed.

looooo commented 2 years ago

great work @bkpoon . @conda-forge/core can we merge this PR?

hmaarrfk commented 2 years ago

thx